openstack
/
manila-specs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 30407 <30407@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 30002 <30002@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 32919 \u003c32919@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Kiran Pawar replied on the change"}
Attention: {"person_ident":"Gerrit User 30407 \u003c30407@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Kiran Pawar replied on the change"}
Attention: {"person_ident":"Gerrit User 30002 \u003c30002@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Kiran Pawar replied on the change"}
This commit is contained in:
Gerrit User 32919 2022-01-17 10:06:25 +00:00 committed by Gerrit Code Review
parent b97e210327
commit 168ada21a1
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
d493fbad831c0db2cdcf0f29b24b4d5942ef0587
View File

@ -16,6 +16,23 @@
"message": "Thks Kiran. Let wait for other reviewers.",
"revId": "d493fbad831c0db2cdcf0f29b24b4d5942ef0587",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f0bd1b9f_68337ee2",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 32919
},
"writtenOn": "2022-01-17T10:06:25Z",
"side": 1,
"message": "As per initial approach there will be four metadata items for each share\n1. auto-snapshot-create-interval\n2. auto-snapshot-delete-interval\n3. last-auto-snapshot-create-time\n4. last-auto-snapshot-delete-time\n\nWe will make it less granular e.g periodic task for snapshot creation will invoke every hour and periodic task for snapshot deletion will invoke every 6 hours.\n\n1. During snapshot creation periodic task\n a. get share metadata and check for value 1 and 3\n b. if current_time- last-auto-snapshot-create-time \u003e\u003d auto-snapshot-create-interval\n create new snapshot and update last-auto-snapshot-create-time\n c. do a and b for all shares in system, if metadata does not exist move to next share.\n\n2. During snapshot creation periodic task\n a. get share metadata and check for value 2 and 4\n b. if current_time- last-auto-snapshot-delete-time \u003e\u003d auto-snapshot-delete-interval\n delete all snapshot with auto_share_xxxx name and update last-auto-snapshot-delete-time \n\nUser specified time for create should be multiple of hour (if not adjusted by manila to nearest possible) and delete should be multiple of 6 hours (if not adjusted by manila to nearest possible).\n\nIn addition, we can have separate service for all periodic tasks in Manila. This will give more control to start individual threads in case more periodic tasks generated. It can be separate blueprint as well.\n\n@Goutham\nWDYT ?",
"revId": "d493fbad831c0db2cdcf0f29b24b4d5942ef0587",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}