openstack
/
manila-specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(4 comments)

Patch-set: 5
This commit is contained in:
Gerrit User 32919 2024-01-10 10:25:27 +00:00 committed by Gerrit Code Review
parent 3ad3d81b3c
commit 31565b96bb
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
eb620542b3e75b689fbefd1d86fdb6505e38827c
View File

@ -40,6 +40,30 @@
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7eaefdc7_de499c75",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 5
},
"lineNbr": 40,
"author": {
"id": 32919
},
"writtenOn": "2024-01-10T10:25:27Z",
"side": 1,
"message": "Done",
"parentUuid": "41b61de4_a176c015",
"range": {
"startLine": 39,
"startChar": 56,
"endLine": 40,
"endChar": 18
},
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -86,6 +110,54 @@
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "74927074_20e60dce",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 5
},
"lineNbr": 53,
"author": {
"id": 32919
},
"writtenOn": "2024-01-10T10:25:27Z",
"side": 1,
"message": "Done",
"parentUuid": "7db60b7e_41cc7765",
"range": {
"startLine": 53,
"startChar": 41,
"endLine": 53,
"endChar": 52
},
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2810a9d2_46fa2378",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 5
},
"lineNbr": 53,
"author": {
"id": 32919
},
"writtenOn": "2024-01-10T10:25:27Z",
"side": 1,
"message": "Done",
"parentUuid": "8706c307_8e5f35be",
"range": {
"startLine": 53,
"startChar": 2,
"endLine": 53,
"endChar": 7
},
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -149,6 +221,24 @@
"message": "I believe the soft delete periodic task also should be modified in case of the default being the deferred deletion, right? I mean, it should set the status to deleting_in_driver and so on...",
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3e5bcc2c_a432c0c9",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 5
},
"lineNbr": 72,
"author": {
"id": 32919
},
"writtenOn": "2024-01-10T10:25:27Z",
"side": 1,
"message": "soft deleted shares are just marked as \u0027soft_deleted\u0027 in db and after retention time out, they are actually deleted. the actual deletion will consider deferred deletion or not, based on config or default value. But it does not affect the core logic of soft deletion. The share_API.delete() should handle it.",
"parentUuid": "4fa67f65_489bb312",
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}