openstack
/
manila-specs
Code Issues Proposed changes

Update patch set 9 

Patch Set 9: Code-Review+1

(1 comment)

Patch-set: 9
Reviewer: Gerrit User 30555 <30555@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 30555 \u003c30555@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Fernando Ferraz replied on the change"}
This commit is contained in:
Gerrit User 30555 2022-01-14 19:21:06 +00:00 committed by Gerrit Code Review
parent 83b9f87a14
commit 319c7caa77
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
7600af4dfdef799af38f1df42b83f751de85b2a0
View File

@ -16,6 +16,23 @@
"message": "thanks for your review.Victoria Martinez de la Cruz and Goutham Pacha Ravi.\n",
"revId": "7600af4dfdef799af38f1df42b83f751de85b2a0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "60fd4f04_2b05229e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 30555
},
"writtenOn": "2022-01-14T19:21:06Z",
"side": 1,
"message": "Hi Haixin, thanks for the very detailed spec. 😊 \nSpec Looks good to me. It\u0027s based on Cinder transfer feature available since Rocky release [1], which seems very convenient and the best approach IMHO, as we can reference Cinder\u0027s code for the implementation, and anticipate issues. Also, customers used to Cinder volume-transfers APIs will find easy to work with Manila transfer APIs.\n\n\n[1] https://docs.openstack.org/releasenotes/cinder/rocky.html",
"revId": "7600af4dfdef799af38f1df42b83f751de85b2a0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}