openstack
/
manila-specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review+1

(1 comment)

Patch-set: 5
Reviewer: Gerrit User 30407 <30407@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 4b3b3b8825b93d8e80706f093eccfeef88bb3532
Attention: {"person_ident":"Gerrit User 30407 \u003c30407@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_30407\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32919 \u003c32919@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_30407\u003e replied on the change"}
This commit is contained in:
Gerrit User 30407 2023-12-19 06:00:36 +00:00 committed by Gerrit Code Review
parent 135bc316a0
commit 35d37d3c58
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
eb620542b3e75b689fbefd1d86fdb6505e38827c Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "fe125a03_4516d704",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 5
},
"lineNbr": 54,
"author": {
"id": 30407
},
"writtenOn": "2023-12-19T06:00:36Z",
"side": 1,
"message": "If user want to change the deletion mode with global configuration, user need to restart the service for the deletion mode to take effect. I even recommend adding a new parameter to delete share so that the user can decide whether to delay deletion or not. add a new micversion to support this. for example:\n\n usage: openstack share delete [-h] [--share-group \u003cshare-group\u003e] [--force]\n [--defer]\n \u003cshare\u003e [\u003cshare\u003e ...]\n \nwhat do you think?",
"range": {
"startLine": 52,
"startChar": 2,
"endLine": 54,
"endChar": 43
},
"revId": "eb620542b3e75b689fbefd1d86fdb6505e38827c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}