openstack
/
manila-specs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+1

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 11604 <11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, b02c822caa9fdfea0857bacfd559f275030b7add
Attention: {"person_ident":"Gerrit User 11604 \u003c11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
This commit is contained in:
Gerrit User 11604 2023-07-03 08:29:07 +00:00 committed by Gerrit Code Review
parent 7414e4f224
commit 4b7c5f3ef4
1 changed files with 57 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
415e52dacbcf6ee4bc3e5332f0fbbf000605acec
View File

@ -33,6 +33,63 @@
"message": "now it is LGTM, thanks.",
"revId": "415e52dacbcf6ee4bc3e5332f0fbbf000605acec",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f2174dc8_974d9bac",
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
"patchSetId": 3
},
"lineNbr": 82,
"author": {
"id": 11604
},
"writtenOn": "2023-07-03T08:29:07Z",
"side": 1,
"message": "+1",
"revId": "415e52dacbcf6ee4bc3e5332f0fbbf000605acec",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a4fa7849_a4813f31",
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
"patchSetId": 3
},
"lineNbr": 87,
"author": {
"id": 11604
},
"writtenOn": "2023-07-03T08:29:07Z",
"side": 1,
"message": "for the nova usecase again i think we need the share and the share access grant to be lockable.\n\nallowing deletion of either would be security issue.",
"revId": "415e52dacbcf6ee4bc3e5332f0fbbf000605acec",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0c2f9781_214fb953",
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
"patchSetId": 3
},
"lineNbr": 125,
"author": {
"id": 11604
},
"writtenOn": "2023-07-03T08:29:07Z",
"side": 1,
"message": "nit: i think you forgot to remove this or update the table",
"range": {
"startLine": 125,
"startChar": 9,
"endLine": 125,
"endChar": 30
},
"revId": "415e52dacbcf6ee4bc3e5332f0fbbf000605acec",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}