openstack
/
manila-specs
Code Issues Proposed changes

Update patch set 10 

Patch Set 10: Code-Review-1

(3 comments)

Patch-set: 10
Reviewer: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, e02da094efe26736f664dc365bf24f408a9e870e
Attention: {"person_ident":"Gerrit User 32919 \u003c32919@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16643 \u003c16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
This commit is contained in:
Gerrit User 16643 2024-02-13 17:25:06 +00:00 committed by Gerrit Code Review
parent a52e78a070
commit 5cad2a4910
1 changed files with 67 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
bcfdc98cbc88fc7f82b5ee395e75aa221d20fd68 Normal file
View File

@ -0,0 +1,67 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "eefa633c_3acc5d21",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 10
},
"lineNbr": 0,
"author": {
"id": 16643
},
"writtenOn": "2024-02-13T17:25:06Z",
"side": 1,
"message": "Thanks for moving the spec; i see a couple of doc build improvements that can be made before merging this",
"revId": "bcfdc98cbc88fc7f82b5ee395e75aa221d20fd68",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b8e2f0a3_12ebe0cb",
"filename": "specs/dalmatian/share_encryption.rst",
"patchSetId": 10
},
"lineNbr": 239,
"author": {
"id": 16643
},
"writtenOn": "2024-02-13T17:25:06Z",
"side": 1,
"message": "enclose commands in a:\n```\n .. code \n \n```\n \nsection. The formatting in the doc o/p is a bit messed up because sphinx thinks the first line of each command is a heading..",
"range": {
"startLine": 235,
"startChar": 0,
"endLine": 239,
"endChar": 34
},
"revId": "bcfdc98cbc88fc7f82b5ee395e75aa221d20fd68",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "589d91b8_2d5bed14",
"filename": "specs/dalmatian/share_encryption.rst",
"patchSetId": 10
},
"lineNbr": 386,
"author": {
"id": 16643
},
"writtenOn": "2024-02-13T17:25:06Z",
"side": 1,
"message": "this neednt be a bulleted list, the doc formatting messes up because of the space added before the second line. Either line up \"data\" to \"Instruct\", or convert this section into a paragraph instead of this list",
"range": {
"startLine": 385,
"startChar": 0,
"endLine": 386,
"endChar": 41
},
"revId": "bcfdc98cbc88fc7f82b5ee395e75aa221d20fd68",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}