openstack
/
manila-specs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 30407 \u003c30407@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_30407\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32919 \u003c32919@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_30407\u003e replied on the change"}
This commit is contained in:
Gerrit User 30407 2023-12-18 09:44:32 +00:00 committed by Gerrit Code Review
parent 90fc0dbc36
commit 6986efe22f
1 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
004c31aa93ddb0057abd94dc79b992d4fa7cfcd6
View File

@ -81,6 +81,30 @@
"revId": "004c31aa93ddb0057abd94dc79b992d4fa7cfcd6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3fed35db_0dea5577",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 4
},
"lineNbr": 60,
"author": {
"id": 30407
},
"writtenOn": "2023-12-18T09:44:32Z",
"side": 1,
"message": "In my opinion, backend storage cleanup is not particularly time-sensitive. I think 300s is fine.",
"parentUuid": "2b14531f_219bf23c",
"range": {
"startLine": 60,
"startChar": 4,
"endLine": 60,
"endChar": 17
},
"revId": "004c31aa93ddb0057abd94dc79b992d4fa7cfcd6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -127,6 +151,30 @@
},
"revId": "004c31aa93ddb0057abd94dc79b992d4fa7cfcd6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e660ec8f_84e80805",
"filename": "specs/caracal/deferred_deletion.rst",
"patchSetId": 4
},
"lineNbr": 67,
"author": {
"id": 30407
},
"writtenOn": "2023-12-18T09:44:32Z",
"side": 1,
"message": "I think we can try to delete it after 30 minutes as you said.\n\n if share[\u0027status\u0027]\u003d\u003d\u0027DELETING_IN_DRIVER_ERROR\u0027:\n interval \u003d now_time - last_updata_at\n if interval \u003e 30mins:\n try to delete again.",
"parentUuid": "f81c4acf_12bf4b11",
"range": {
"startLine": 65,
"startChar": 71,
"endLine": 67,
"endChar": 37
},
"revId": "004c31aa93ddb0057abd94dc79b992d4fa7cfcd6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}