openstack
/
manila-specs
Code Issues Proposed changes

Update patch set 16 

Patch Set 16: Code-Review+2

(1 comment)

Patch-set: 16
Reviewer: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 88fba3afda8dcf54444ed20aa6aa6086e8cfd642
Attention: {"person_ident":"Gerrit User 32919 \u003c32919@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16643 \u003c16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
This commit is contained in:
Gerrit User 16643 2024-03-05 23:31:04 +00:00 committed by Gerrit Code Review
parent 3024a1b06f
commit bdf6a579d6
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
dcfd3ad11f24298e826b59878f1d880beb8f6473
View File

@ -16,6 +16,23 @@
"message": "instead of adding encryption_key_id to shares and share_snapshots table, changed to add in share_instances and share_snapshot_instances since share_instance is what we pass to backend driver to create share. So we will pass encryption_key_id as part of share_instance object itself.",
"revId": "dcfd3ad11f24298e826b59878f1d880beb8f6473",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "33604d05_a247da0c",
"filename": "specs/dalmatian/share_encryption.rst",
"patchSetId": 16
},
"lineNbr": 150,
"author": {
"id": 16643
},
"writtenOn": "2024-03-05T23:31:04Z",
"side": 1,
"message": "add a blank line above for this list to be formatted properly",
"revId": "dcfd3ad11f24298e826b59878f1d880beb8f6473",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}