Update patch set 3
Patch Set 3:
(16 comments)
Patch-set: 3
Attention: {"person_ident":"Gerrit User 16643 \u003c16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
This commit is contained in:
Gerrit User 16643
Gerrit Code Review
parent
1cca96be56
commit
cf20651f8b
|
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "0ea5d4ea_1852b541",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Thank you for the further comments, Sean and Thiago. I\u0027ve responded inline and made some modifications.",
|
||||
"revId": "415e52dacbcf6ee4bc3e5332f0fbbf000605acec",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -759,6 +759,30 @@
|
|||
},
|
||||
"revId": "d469d5e4e2242618435add2e01ed7bd91b5a6f7e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "61fff35e_e2b40c71",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 551,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "e6768903_c207f295",
|
||||
"range": {
|
||||
"startLine": 551,
|
||||
"startChar": 44,
|
||||
"endLine": 551,
|
||||
"endChar": 58
|
||||
},
|
||||
"revId": "d469d5e4e2242618435add2e01ed7bd91b5a6f7e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -74,6 +74,30 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "a87277dc_852d2306",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 84,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "ack;",
|
||||
"parentUuid": "f4fd6f26_98df0d13",
|
||||
"range": {
|
||||
"startLine": 83,
|
||||
"startChar": 39,
|
||||
"endLine": 84,
|
||||
"endChar": 55
|
||||
},
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -97,6 +121,30 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e9c1ce34_4e692728",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 108,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Yes, it will be implemented as an enum; I clarified this below.",
|
||||
"parentUuid": "ce66924e_fd7e49a5",
|
||||
"range": {
|
||||
"startLine": 108,
|
||||
"startChar": 10,
|
||||
"endLine": 108,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -120,6 +168,30 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e4e4c864_804aeb97",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 113,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "i started implemehting this, and realized that we soft-delete database entries, so this had to be varchar(36) for that logic to work, the default will be \"false\"",
|
||||
"parentUuid": "fe139cd7_648bf743",
|
||||
"range": {
|
||||
"startLine": 113,
|
||||
"startChar": 10,
|
||||
"endLine": 113,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -143,6 +215,30 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "0dc87423_00d8fddb",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 138,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Thanks; 200 would be more appropriate since we\u0027re returning content",
|
||||
"parentUuid": "b143ff9c_c276ae41",
|
||||
"range": {
|
||||
"startLine": 138,
|
||||
"startChar": 0,
|
||||
"endLine": 138,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -190,6 +286,30 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "357d9a71_6a644675",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 145,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Thanks; The resource that is invalid/not-found is in the request body; 404 would be appropriate if it was in the URL",
|
||||
"parentUuid": "5daca88e_0c5b1c56",
|
||||
"range": {
|
||||
"startLine": 145,
|
||||
"startChar": 2,
|
||||
"endLine": 145,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -213,6 +333,30 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "1bd97c65_566f3182",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 148,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "eb82d351_4a6efd71",
|
||||
"range": {
|
||||
"startLine": 148,
|
||||
"startChar": 0,
|
||||
"endLine": 148,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -236,6 +380,30 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "dc8548cd_5bcb4558",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 177,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Done; thanks for the links and the explanation!",
|
||||
"parentUuid": "9821bda4_c98bb7b7",
|
||||
"range": {
|
||||
"startLine": 165,
|
||||
"startChar": 0,
|
||||
"endLine": 177,
|
||||
"endChar": 5
|
||||
},
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -259,6 +427,30 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f109dd15_000a3dee",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 198,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "i need to remove this; the \"resource_id\" isn\u0027t permitted in the request body..",
|
||||
"parentUuid": "4f639028_4fc90421",
|
||||
"range": {
|
||||
"startLine": 198,
|
||||
"startChar": 2,
|
||||
"endLine": 198,
|
||||
"endChar": 5
|
||||
},
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -276,6 +468,24 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "47afac1b_3e3cc18b",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 202,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Done; dropping 406 everywhere",
|
||||
"parentUuid": "b75e81b9_a8edda03",
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -299,6 +509,30 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "940f02c4_784a31e3",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 230,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "You mean the request and response schema? If yes, this DELETE method doesn\u0027t permit any body nor does it return any response body.. its stated after the Expected http error code(s) below..",
|
||||
"parentUuid": "fdff97ca_5e471930",
|
||||
"range": {
|
||||
"startLine": 230,
|
||||
"startChar": 2,
|
||||
"endLine": 230,
|
||||
"endChar": 48
|
||||
},
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -316,6 +550,24 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "d1566c0a_5314815b",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 239,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5895c914_3b5aa467",
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -333,6 +585,24 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "ee277231_07421593",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 248,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "0170b7c3_e5d7d670",
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -356,6 +626,30 @@
|
|||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e11a2d19_b3ee179d",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 257,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "Deleted records aren\u0027t accessible via the API.. these would only be viewable by performing a db dump; and one may do that for audit purposes..",
|
||||
"parentUuid": "e6916a1c_a0a51b53",
|
||||
"range": {
|
||||
"startLine": 256,
|
||||
"startChar": 19,
|
||||
"endLine": 257,
|
||||
"endChar": 28
|
||||
},
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -372,6 +666,24 @@
|
|||
"message": "so this is an aync operation correct.",
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "a1323978_5643b8bf",
|
||||
"filename": "specs/bobcat/allow-locking-shares-against-deletion.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 336,
|
||||
"author": {
|
||||
"id": 16643
|
||||
},
|
||||
"writtenOn": "2023-06-30T07:13:30Z",
|
||||
"side": 1,
|
||||
"message": "yes, share deletion is async..",
|
||||
"parentUuid": "0d55a987_a9be181b",
|
||||
"revId": "db6ae3f55811a8a338d974077a36a1b5bfa8dab3",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue