openstack
/
manila-specs
Code Issues Proposed changes
manila-specs/e64af4d2075bc78bbe7801856ca...

341 lines
10 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "3690f89f_fbe74dcb",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 81,
"author": {
"id": 16643
},
"writtenOn": "2023-10-25T00:03:02Z",
"side": 1,
"message": "this is a bit unclear; what is the \"backend driver\" here? \n\nwe use that terminology for share backend drivers such as the CephFS driver, or the NetApp ONTAP driver.. \n\ndo you mean the share manager will have a barbican client layer?",
"range": {
"startLine": 69,
"startChar": 27,
"endLine": 81,
"endChar": 70
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a1c9d241_d64ec2fd",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 81,
"author": {
"id": 18816
},
"writtenOn": "2023-10-27T08:23:33Z",
"side": 1,
"message": "Something like https://review.opendev.org/c/openstack/cinder/+/39292, I think",
"parentUuid": "3690f89f_fbe74dcb",
"range": {
"startLine": 69,
"startChar": 27,
"endLine": 81,
"endChar": 70
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "39b7cef5_36bb72e5",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 81,
"author": {
"id": 32919
},
"writtenOn": "2023-10-27T12:07:11Z",
"side": 1,
"message": "Added reference of key manager.\n\n1. manila API (talks with key manager to get encryption key)\n2. manila API gets encryption key ref from user\n\nin both case, it will be passed to backend as it is. The backend then using either key or key ref talks with key store and does encryption.",
"parentUuid": "a1c9d241_d64ec2fd",
"range": {
"startLine": 69,
"startChar": 27,
"endLine": 81,
"endChar": 70
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ba78e1c9_4b5fb2a4",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 113,
"author": {
"id": 29632
},
"writtenOn": "2023-10-25T20:44:12Z",
"side": 1,
"message": "should we have a status of some sort? I\u0027m unsure how long it would take to encrypt a share, and if that fails, what would happen?",
"range": {
"startLine": 111,
"startChar": 0,
"endLine": 113,
"endChar": 73
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f6a40da1_46d2390e",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 113,
"author": {
"id": 32919
},
"writtenOn": "2023-10-27T12:07:11Z",
"side": 1,
"message": "the encryption happens on backend today as well and its not reflected in either status. So we wont need status with this addition as well.",
"parentUuid": "ba78e1c9_4b5fb2a4",
"range": {
"startLine": 111,
"startChar": 0,
"endLine": 113,
"endChar": 73
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f9f1a3eb_f6294ac3",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 113,
"author": {
"id": 30407
},
"writtenOn": "2023-12-04T07:49:20Z",
"side": 1,
"message": "yes, i agree with Kiran Pawar, Encryption is a back-end storage feature, and manila tells the storage that the share is encrypted and what the encryption key is when it creates a share through the drive.\n\nThen, after the share is mounted, the data will be encrypted only when the data IO is generated.",
"parentUuid": "f6a40da1_46d2390e",
"range": {
"startLine": 111,
"startChar": 0,
"endLine": 113,
"endChar": 73
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "545bcc96_ba190fe9",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 154,
"author": {
"id": 29632
},
"writtenOn": "2023-10-25T20:44:12Z",
"side": 1,
"message": "are you planning to implement new commands also be provided to the new encryption API?",
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "954c7f34_1146420b",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 154,
"author": {
"id": 32919
},
"writtenOn": "2023-10-27T12:07:11Z",
"side": 1,
"message": "the encryption with share type will be API interfaces, For manilaclient there wont be new commands, but there will be new params to existing share type comamnds.",
"parentUuid": "545bcc96_ba190fe9",
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f678418e_94f4f4c3",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 154,
"author": {
"id": 30407
},
"writtenOn": "2023-12-04T07:49:20Z",
"side": 1,
"message": "i agree with Carlos Eduardo. please see my comments.",
"parentUuid": "954c7f34_1146420b",
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4f1b2951_e90a33fb",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 191,
"author": {
"id": 29632
},
"writtenOn": "2023-10-25T20:44:12Z",
"side": 1,
"message": "I believe this is kind of a duplicate of what\u0027s described between lines 163 and 167 right?",
"range": {
"startLine": 185,
"startChar": 0,
"endLine": 191,
"endChar": 48
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2678e42e_7849f29d",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 191,
"author": {
"id": 32919
},
"writtenOn": "2023-10-27T12:07:11Z",
"side": 1,
"message": "yes, just added the information of that particular command. Should I remove it ?",
"parentUuid": "4f1b2951_e90a33fb",
"range": {
"startLine": 185,
"startChar": 0,
"endLine": 191,
"endChar": 48
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8da6cf7e_23130726",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 191,
"author": {
"id": 29632
},
"writtenOn": "2024-01-09T13:38:24Z",
"side": 1,
"message": "I\u0027m okay if you want to leave it :)",
"parentUuid": "2678e42e_7849f29d",
"range": {
"startLine": 185,
"startChar": 0,
"endLine": 191,
"endChar": 48
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8392caa9_b474fbb9",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 191,
"author": {
"id": 32919
},
"writtenOn": "2024-02-05T11:02:59Z",
"side": 1,
"message": "Done",
"parentUuid": "8da6cf7e_23130726",
"range": {
"startLine": 185,
"startChar": 0,
"endLine": 191,
"endChar": 48
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ad9dce3b_e1d514c7",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 387,
"author": {
"id": 18816
},
"writtenOn": "2023-10-27T08:23:33Z",
"side": 1,
"message": "Copy\u0026Paste error from backup spec?\n\nI did not find a cinder spec/blueprint - but there are some reviews at https://review.opendev.org/q/topic:bp%252Fencrypt-cinder-volumes",
"range": {
"startLine": 387,
"startChar": 8,
"endLine": 387,
"endChar": 85
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "72f5d9d9_4187e31d",
"filename": "specs/caracal/share_encryption.rst",
"patchSetId": 2
},
"lineNbr": 387,
"author": {
"id": 32919
},
"writtenOn": "2023-10-27T12:07:11Z",
"side": 1,
"message": "Done",
"parentUuid": "ad9dce3b_e1d514c7",
"range": {
"startLine": 387,
"startChar": 8,
"endLine": 387,
"endChar": 85
},
"revId": "e64af4d2075bc78bbe7801856ca1bfbcafadbf5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink