openstack/manila-tempest-plugin
Code Issues Proposed changes

Follow up fixes to recycle bin tests

Browse Source 
For the sake of correctness and readability, the negative
tests to soft-delete or restore with an incorrect ID must
use the default ("primary" user) client in the class. While
it's okay to use whatever client, someone reading these tests
may be confused if the tests are supposed to work with the
default client.

TrivialFix

Change-Id: Ic2735cb3a852af6f8a2edf44a501ba612391ae24
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
This commit is contained in:
Goutham Pacha Ravi 2022-02-21 16:10:15 -08:00
parent 1c5e68da5e
commit 287883813f
1 changed files with 2 additions and 2 deletions

4
manila_tempest_tests/tests/api/test_shares_actions_negative.py

@ -350,7 +350,7 @@ class SharesActionsNegativeTest(base.BaseSharesMixedTest):
@tc.attr(base.TAG_NEGATIVE, base.TAG_API)
def test_soft_delete_share_with_wrong_id(self):
self.assertRaises(lib_exc.NotFound,
self.alt_shares_v2_client.soft_delete_share,
self.shares_v2_client.soft_delete_share,
"wrong_share_id")
@utils.skip_if_microversion_not_supported("2.69")
@ -358,5 +358,5 @@ class SharesActionsNegativeTest(base.BaseSharesMixedTest):
@tc.attr(base.TAG_NEGATIVE, base.TAG_API)
def test_restore_share_with_wrong_id(self):
self.assertRaises(lib_exc.NotFound,
self.alt_shares_v2_client.restore_share,
self.shares_v2_client.restore_share,
"wrong_share_id")