diff --git a/129fd1cc40a1b5ee671b86d66945acbbc35c8dfe b/129fd1cc40a1b5ee671b86d66945acbbc35c8dfe index 62542d78..a2c22455 100644 --- a/129fd1cc40a1b5ee671b86d66945acbbc35c8dfe +++ b/129fd1cc40a1b5ee671b86d66945acbbc35c8dfe @@ -16,6 +16,103 @@ "message": "recheck\nLogs are gone", "revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "cacf7def_746f90cc", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 10 + }, + "lineNbr": 0, + "author": { + "id": 16643 + }, + "writtenOn": "2024-01-27T00:53:32Z", + "side": 1, + "message": "Hey Carlos; thanks for the changes.. i\u0027ve a few more comments..", + "revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "4837eee3_d3633b66", + "filename": "manila_tempest_tests/tests/api/test_rules.py", + "patchSetId": 10 + }, + "lineNbr": 545, + "author": { + "id": 16643 + }, + "writtenOn": "2024-01-27T00:53:32Z", + "side": 1, + "message": "minor nit:\n\ncan you call this: `expected_access_to`\n\nit\u0027ll enhance readability", + "range": { + "startLine": 545, + "startChar": 8, + "endLine": 545, + "endChar": 17 + }, + "revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "47c94547_915a958f", + "filename": "manila_tempest_tests/tests/api/test_rules.py", + "patchSetId": 10 + }, + "lineNbr": 546, + "author": { + "id": 16643 + }, + "writtenOn": "2024-01-27T00:53:32Z", + "side": 1, + "message": "same", + "revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "15826673_370f788c", + "filename": "manila_tempest_tests/tests/api/test_rules.py", + "patchSetId": 10 + }, + "lineNbr": 550, + "author": { + "id": 16643 + }, + "writtenOn": "2024-01-27T00:53:32Z", + "side": 1, + "message": "instead of looping, extract the rule you want:\n\n```\n rule_latest_rules_api \u003d [r for r in rules if r[\u0027id\u0027] \u003d\u003d rule[\u0027id\u0027]][0]\n rule_lower_version_rules_api \u003d [r for r in rules_get_lower_version\n if r[\u0027id\u0027] \u003d\u003d rule[\u0027id\u0027]][0]\n\n```\n\nit\u0027s still O(n) and we wouldn\u0027t need the \u0027break\u0027", + "range": { + "startLine": 549, + "startChar": 8, + "endLine": 550, + "endChar": 41 + }, + "revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "62a8bb76_b6d6e33b", + "filename": "manila_tempest_tests/tests/api/test_rules_negative.py", + "patchSetId": 10 + }, + "lineNbr": 205, + "author": { + "id": 16643 + }, + "writtenOn": "2024-01-27T00:53:32Z", + "side": 1, + "message": "the name here can include the parameter so its easier to catch the test case in the o/p:\n\n```\n test_deny_access_without_unrestrict_as_owner_user(self, same_user):\n```", + "revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file diff --git a/b0c5d0b9f66149f4a7d34abd477d23a5b43f716e b/b0c5d0b9f66149f4a7d34abd477d23a5b43f716e index c6007569..49e36675 100644 --- a/b0c5d0b9f66149f4a7d34abd477d23a5b43f716e +++ b/b0c5d0b9f66149f4a7d34abd477d23a5b43f716e @@ -116,6 +116,30 @@ "revId": "b0c5d0b9f66149f4a7d34abd477d23a5b43f716e", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": true, + "key": { + "uuid": "08b4329d_cf179250", + "filename": "manila_tempest_tests/tests/api/test_rules.py", + "patchSetId": 8 + }, + "lineNbr": 580, + "author": { + "id": 16643 + }, + "writtenOn": "2024-01-27T00:53:32Z", + "side": 1, + "message": "yes, that\u0027s why \"assertFalse\".. but, \n\nI see that you inverted the condition below.. \n\nThis should be either:\n\n```\nself.assertFalse(rules[0][\u0027access_key\u0027] \u003d\u003d \u0027******\u0027)\n\n```\n\nor\n\n```\nself.assertTrue(rules[0][\u0027access_key\u0027] !\u003d \u0027******\u0027)\n\n```\n\nSo i\u0027m confused how this test is passing.", + "parentUuid": "006b59f3_269ba6de", + "range": { + "startLine": 580, + "startChar": 12, + "endLine": 580, + "endChar": 56 + }, + "revId": "b0c5d0b9f66149f4a7d34abd477d23a5b43f716e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": {