openstack
/
manila-tempest-plugin
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(4 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 36180 \u003c36180@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36180\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16643 \u003c16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36180\u003e replied on the change"}
This commit is contained in:
Gerrit User 36180 2023-10-19 16:06:28 +00:00 committed by Gerrit Code Review
parent f1e02f85af
commit 62b9d714cb
2 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
ba3acbfc1109eb3b957437d6c8c943c2675072e2
View File

@ -169,6 +169,30 @@
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "21e7ca70_5d6b00c6",
"filename": "manila_tempest_tests/common/waiters.py",
"patchSetId": 1
},
"lineNbr": 49,
"author": {
"id": 36180
},
"writtenOn": "2023-10-19T16:06:28Z",
"side": 1,
"message": "done",
"parentUuid": "2aa268ea_4b6d6c21",
"range": {
"startLine": 49,
"startChar": 29,
"endLine": 49,
"endChar": 42
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -286,6 +310,54 @@
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "17c3b47a_007a8e58",
"filename": "manila_tempest_tests/tests/api/admin/test_share_servers_migration.py",
"patchSetId": 1
},
"lineNbr": 285,
"author": {
"id": 36180
},
"writtenOn": "2023-10-19T16:06:28Z",
"side": 1,
"message": "done",
"parentUuid": "25caff96_3585619d",
"range": {
"startLine": 285,
"startChar": 8,
"endLine": 285,
"endChar": 16
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "30e6e14b_568b0c6d",
"filename": "manila_tempest_tests/tests/api/admin/test_share_servers_migration.py",
"patchSetId": 1
},
"lineNbr": 285,
"author": {
"id": 36180
},
"writtenOn": "2023-10-19T16:06:28Z",
"side": 1,
"message": "Done",
"parentUuid": "25caff96_3585619d",
"range": {
"startLine": 285,
"startChar": 8,
"endLine": 285,
"endChar": 16
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

18
c699fca328537fb0f0371fea92afeaa514d5e2f1
View File

@ -16,6 +16,24 @@
"message": "We\u0027ve a pending change that should be merged soon that fixes the failing RBAC tests.. https://review.opendev.org/c/openstack/manila-tempest-plugin/+/872260\n\nso zuul will -1 this until that patch merges",
"revId": "c699fca328537fb0f0371fea92afeaa514d5e2f1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c3447ef9_c8632868",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 36180
},
"writtenOn": "2023-10-19T16:06:28Z",
"side": 1,
"message": "Thanks for this info",
"parentUuid": "dcdc3402_f0d57e01",
"revId": "c699fca328537fb0f0371fea92afeaa514d5e2f1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}