From 8f333bd3090cd9309f20df74c4cb9aa73ac2ed22 Mon Sep 17 00:00:00 2001 From: Goutham Pacha Ravi Date: Fri, 19 Jun 2020 13:54:22 -0700 Subject: [PATCH] [ci] Use dynamic credential provider in DHSS=False tests Manila's tempest tests create test credentials on the fly using tempest's dynamic test credential framework. Launchpad bug 1883795 points to an issue where we're forcing the creation of test accounts dynamically even when "[auth]/use_dynamic_credentials" has been set to False. The appropriate fix [0] for that bug is to skip tests that *require* a new test credential. This leads us to lose test coverage in such a situation. Currently, manila tempest tests cannot be run reliably with dynamic credentials when testing DHSS=True drivers. See bugs [1][2][3][4]; So these tests use the pre-provisioned test credentials framework as a workaround. We plan to fix this soon [5]. In the meantime, we don't want to lose test coverage by turning off dynamic credentials all the time. So ensure we're running with dynamic creds turned on for all test jobs except the DHSS=True jobs. After [5] merges, we can turn on dynamic credentials everywhere. [0] https://review.opendev.org/736195/ [1] https://launchpad.net/bugs/1762900 [2] https://launchpad.net/bugs/1604732 [3] https://launchpad.net/bugs/1607069 [4] https://launchpad.net/bugs/1679715 [5] https://review.opendev.org/728604/ Change-Id: I48c41fd197118e5fd701e9e8056802c8c0895410 Related-Bug: #1883795 Signed-off-by: Goutham Pacha Ravi --- zuul.d/manila-tempest-jobs.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/zuul.d/manila-tempest-jobs.yaml b/zuul.d/manila-tempest-jobs.yaml index 56cc9d8a..b2b0e1e4 100644 --- a/zuul.d/manila-tempest-jobs.yaml +++ b/zuul.d/manila-tempest-jobs.yaml @@ -39,7 +39,6 @@ tls-proxy: true devstack_localrc: USE_PYTHON3: true - TEMPEST_USE_TEST_ACCOUNTS: true MANILA_USE_DOWNGRADE_MIGRATIONS: true MANILA_INSTALL_TEMPEST_PLUGIN_SYSTEMWIDE: false MANILA_ALLOW_NAS_SERVER_PORTS_ON_HOST: true @@ -151,7 +150,7 @@ - job: name: manila-tempest-plugin-container description: | - Test the container driver multibackend (DHSS=False) with CIFS + Test the container driver multibackend (DHSS=True) with CIFS and postgresql db. API only, in a minimal devstack parent: manila-tempest-plugin-base vars: @@ -169,6 +168,7 @@ SHARE_BACKING_FILE_SIZE: 64000M MANILA_CONFIGURE_DEFAULT_TYPES: false MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS: 'snapshot_support=false' + TEMPEST_USE_TEST_ACCOUNTS: true devstack_services: mysql: false postgresql: true @@ -211,6 +211,7 @@ MANILA_OPTGROUP_paris_driver_handles_share_servers: true MANILA_USE_SERVICE_INSTANCE_PASSWORD: true MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS: 'snapshot_support=True create_share_from_snapshot_support=True' + TEMPEST_USE_TEST_ACCOUNTS: true devstack_services: cinder: true devstack_local_conf: