openstack
/
manila-tempest-plugin
Code Issues Proposed changes

Fix check to server migration complete test 

The patch [1] added an extra check to migration complete test
waiting for the source share server to be deleted. However, this
behavior is not for all releases, only after Wallaby release. So,
this patch fixed the problem by only checking with the expected releases.

[1] https://review.opendev.org/c/openstack/manila-tempest-plugin/+/808834

Change-Id: Ic0b0773e3baa3904bc5c28307772da425f77b6de
This commit is contained in:
Felipe Rodrigues 2021-09-22 16:19:30 -03:00
parent a4fab9a60e
commit 9c4a97b150
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
manila_tempest_tests/tests/api/admin/test_share_servers_migration.py
View File

@ -388,8 +388,11 @@ class ShareServerMigrationBasicNFS(MigrationShareServerBase):
self._validate_share_server_migration_complete(
share, dest_host, dest_server_id, snapshot_id=snapshot_id,
share_network_id=dest_share_network_id)
self.admin_shares_client.wait_for_resource_deletion(
server_id=src_server_id)
# Source share server is only deleted after Wallaby release (2.63).
if utils.is_microversion_gt(CONF.share.max_api_microversion, "2.63"):
self.admin_shares_client.wait_for_resource_deletion(
server_id=src_server_id)
@decorators.idempotent_id('52e154eb-2d39-45af-b5c1-49ea569ab804')
@tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)