From a3255045efef5002378c9e1cdd5ddd02c4883bca Mon Sep 17 00:00:00 2001 From: lkuchlan Date: Thu, 27 Oct 2022 11:37:13 +0300 Subject: [PATCH] Remove "alt_project_share_v2_client" client initialization It's already initialized in the base classes. Change-Id: Id7e4bf5fb9aaf2dc32a7bebac3a29fb730015f70 --- manila_tempest_tests/tests/rbac/test_share_network.py | 10 ++-------- manila_tempest_tests/tests/rbac/test_shares.py | 8 -------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/manila_tempest_tests/tests/rbac/test_share_network.py b/manila_tempest_tests/tests/rbac/test_share_network.py index c1ca6a2c..3665b6b3 100644 --- a/manila_tempest_tests/tests/rbac/test_share_network.py +++ b/manila_tempest_tests/tests/rbac/test_share_network.py @@ -35,6 +35,8 @@ class ShareRbacShareNetworkTests(rbac_base.ShareRbacBaseTests, super(ShareRbacShareNetworkTests, cls).setup_clients() cls.persona = getattr(cls, 'os_%s' % cls.credentials[0]) cls.client = cls.persona.share_v2.SharesV2Client() + cls.alt_project_share_v2_client = ( + cls.os_project_alt_member.share_v2.SharesV2Client()) @classmethod def resource_setup(cls): @@ -72,8 +74,6 @@ class ProjectAdminTests(ShareRbacShareNetworkTests, base.BaseSharesTest): project_member = cls.setup_user_client( cls.persona, project_id=cls.persona.credentials.project_id) cls.share_member_client = project_member.share_v2.SharesV2Client() - cls.alt_project_share_v2_client = ( - cls.os_project_alt_member.share_v2.SharesV2Client()) @decorators.idempotent_id('358dd850-cd81-4b81-aefa-3dfcb7aa4551') @tc.attr(base.TAG_POSITIVE, base.TAG_API) @@ -148,12 +148,6 @@ class ProjectMemberTests(ShareRbacShareNetworkTests, base.BaseSharesTest): credentials = ['project_member', 'project_alt_member'] - @classmethod - def setup_clients(cls): - super(ProjectMemberTests, cls).setup_clients() - cls.alt_project_share_v2_client = ( - cls.os_project_alt_member.share_v2.SharesV2Client()) - @decorators.idempotent_id('d051c749-3d1c-4485-86c5-6eb860b49cad') @tc.attr(base.TAG_POSITIVE, base.TAG_API) def test_create_share_network(self): diff --git a/manila_tempest_tests/tests/rbac/test_shares.py b/manila_tempest_tests/tests/rbac/test_shares.py index f6f5297a..ad6bb358 100644 --- a/manila_tempest_tests/tests/rbac/test_shares.py +++ b/manila_tempest_tests/tests/rbac/test_shares.py @@ -119,8 +119,6 @@ class TestProjectAdminTestsNFS(ShareRbacSharesTests, base.BaseSharesTest): project_member = cls.setup_user_client( cls.persona, project_id=cls.persona.credentials.project_id) cls.share_member_client = project_member.share_v2.SharesV2Client() - cls.alt_project_share_v2_client = ( - cls.os_project_alt_member.share_v2.SharesV2Client()) @decorators.idempotent_id('14a52454-cba0-4973-926a-28e924ae2e63') @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND) @@ -322,12 +320,6 @@ class TestProjectMemberTestsNFS(ShareRbacSharesTests, base.BaseSharesTest): credentials = ['project_member', 'project_alt_member'] protocol = 'nfs' - @classmethod - def setup_clients(cls): - super(TestProjectMemberTestsNFS, cls).setup_clients() - cls.alt_project_share_v2_client = ( - cls.os_project_alt_member.share_v2.SharesV2Client()) - @decorators.idempotent_id('75b9fd40-ae63-4caf-9c93-0fe24b2ce904') @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND) def test_get_share(self):