openstack/manila-tempest-plugin
Code Issues Proposed changes

Fix tests creating share without using share_size

Browse Source 
Some tests from share group and replication are not creating
share following the `share_size` tempest CONF. This patch
fixed them applying that configuration.

Change-Id: If525e97a5d456d6ddebb4bf9bc8ff6190c95a555
This commit is contained in:
Felipe Rodrigues 2021-08-10 22:00:21 -03:00
parent da415b4f1c
commit bef40b3f80
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manila_tempest_tests/tests/api/admin/test_replication_actions.py
View File

@ -114,7 +114,7 @@ class ReplicationActionsAdminTest(base.BaseSharesMixedTest):
def test_manage_share_for_replication_type(self):
"""Manage a share with replication share type."""
# Create a share and unmanage it
share = self.create_share(size=2,
share = self.create_share(size=CONF.share.share_size,
share_type_id=self.share_type_id,
availability_zone=self.share_zone,
share_network_id=self.sn_id,
@ -164,7 +164,7 @@ class ReplicationActionsAdminTest(base.BaseSharesMixedTest):
'Manage/Unmanage Tests are disabled.')
def test_unmanage_replicated_share_with_no_replica(self):
"""Unmanage a replication type share that does not have replica."""
share = self.create_share(size=2,
share = self.create_share(size=CONF.share.share_size,
share_type_id=self.share_type_id,
share_network_id=self.sn_id,
availability_zone=self.share_zone,

4
manila_tempest_tests/tests/api/test_share_group_actions.py
View File

@ -80,8 +80,8 @@ class ShareGroupActionsTest(base.BaseSharesMixedTest):
# Create 2 shares - inside first and second share groups
cls.share_name = data_utils.rand_name("tempest-share-name")
cls.share_desc = data_utils.rand_name("tempest-share-description")
cls.share_size = 1
cls.share_size2 = 2
cls.share_size = CONF.share.share_size
cls.share_size2 = CONF.share.share_size + 2
cls.shares = cls.create_shares([
{'kwargs': {
'name': cls.share_name,

2
manila_tempest_tests/tests/api/test_share_groups_negative.py
View File

@ -65,7 +65,7 @@ class ShareGroupsNegativeTest(base.BaseSharesMixedTest):
# Create a share in the share group
cls.share_name = data_utils.rand_name("tempest-share-name")
cls.share_desc = data_utils.rand_name("tempest-share-description")
cls.share_size = 1
cls.share_size = CONF.share.share_size
cls.share = cls.create_share(
name=cls.share_name,
description=cls.share_desc,