openstack
/
manila-tempest-plugin
Code Issues Proposed changes

Fix parsing of share group type json 

When using the shares client, since
86f2432476,
JSON objects from the response body are extracted in-place
rather than in the client methods. We didn't catch this issue
when merging [1] because these tests are skipped in the jobs
running against manila-tempest-plugin:

manila_tempest_tests.tests.api.admin.test_share_groups.ShareGroupsTest.test_default_share_group_type_applied_1_2_31 ... SKIPPED: Only if defaults are defined.
manila_tempest_tests.tests.api.admin.test_share_groups.ShareGroupsTest.test_default_share_group_type_applied_2_2_55 ... SKIPPED: Only if defaults are defined.
manila_tempest_tests.tests.api.admin.test_share_groups.ShareGroupsTest.test_default_share_group_type_applied_3_2_61 ... SKIPPED: Only if defaults are defined.

However, default share and group types are defined in the
grenade job and these tests are currently failing.

Change-Id: Ida39026d655d34af17846cd45867c2d46141f39f
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
This commit is contained in:
Goutham Pacha Ravi 2021-07-27 15:29:53 -07:00
parent 86f2432476
commit da415b4f1c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manila_tempest_tests/tests/api/admin/test_share_groups.py
View File

@ -148,7 +148,7 @@ class ShareGroupsTest(base.BaseSharesAdminTest):
try:
default_type = self.shares_v2_client.get_default_share_group_type(
version=version
)
)['share_group_type']
except exceptions.NotFound:
msg = "There is no default share group type"
raise self.skipException(msg)