Update patch set 3

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 36180 \u003c36180@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36180\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16643 \u003c16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36180\u003e replied on the change"}

ba3acbfc1109eb3b957437d6c8c943c2675072e2

@@ -428,6 +428,30 @@
       },
       "revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "8e0cdfb4_b826d527",
+        "filename": "manila_tempest_tests/tests/api/base.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 213,
+      "author": {
+        "id": 36180
+      },
+      "writtenOn": "2023-10-30T09:59:14Z",
+      "side": 1,
+      "message": "Hi Goutham, just wanted to correct myself here. Even we remove this check non of the test will failed. Initially, CIFS related tests were failing in our environment due to security service was not associated with share network. I have added \"security_service\" parameter in out tempest file and added the code in my test to associate the security service to share network, but it failed with error \"security services already associated with share network\", then I have added this code in lib. Later (after playing with code) I realize that we are creating the share network and adding the security service to share network as part of test setup. I remove the code from my test but I keep the code in lib which return if security service is already associated with share network.\n\nIf you want I can remove this code but I feel adding this validation is good as we can add only one security service to share network (plz correct me if I am wrong here) and if it is already exist then return once condition meet. As of now non of the test case might hit this but in future we can hit this kind of issue.",
+      "parentUuid": "58326e30_0207d8b0",
+      "range": {
+        "startLine": 208,
+        "startChar": 8,
+        "endLine": 213,
+        "endChar": 18
+      },
+      "revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }