118 lines
3.6 KiB
Plaintext
118 lines
3.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8e7f028a_e9da91b8",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 29632
|
|
},
|
|
"writtenOn": "2024-01-22T12:30:33Z",
|
|
"side": 1,
|
|
"message": "recheck\nLogs are gone",
|
|
"revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "cacf7def_746f90cc",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2024-01-27T00:53:32Z",
|
|
"side": 1,
|
|
"message": "Hey Carlos; thanks for the changes.. i\u0027ve a few more comments..",
|
|
"revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4837eee3_d3633b66",
|
|
"filename": "manila_tempest_tests/tests/api/test_rules.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 545,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2024-01-27T00:53:32Z",
|
|
"side": 1,
|
|
"message": "minor nit:\n\ncan you call this: `expected_access_to`\n\nit\u0027ll enhance readability",
|
|
"range": {
|
|
"startLine": 545,
|
|
"startChar": 8,
|
|
"endLine": 545,
|
|
"endChar": 17
|
|
},
|
|
"revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "47c94547_915a958f",
|
|
"filename": "manila_tempest_tests/tests/api/test_rules.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 546,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2024-01-27T00:53:32Z",
|
|
"side": 1,
|
|
"message": "same",
|
|
"revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "15826673_370f788c",
|
|
"filename": "manila_tempest_tests/tests/api/test_rules.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 550,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2024-01-27T00:53:32Z",
|
|
"side": 1,
|
|
"message": "instead of looping, extract the rule you want:\n\n```\n rule_latest_rules_api \u003d [r for r in rules if r[\u0027id\u0027] \u003d\u003d rule[\u0027id\u0027]][0]\n rule_lower_version_rules_api \u003d [r for r in rules_get_lower_version\n if r[\u0027id\u0027] \u003d\u003d rule[\u0027id\u0027]][0]\n\n```\n\nit\u0027s still O(n) and we wouldn\u0027t need the \u0027break\u0027",
|
|
"range": {
|
|
"startLine": 549,
|
|
"startChar": 8,
|
|
"endLine": 550,
|
|
"endChar": 41
|
|
},
|
|
"revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "62a8bb76_b6d6e33b",
|
|
"filename": "manila_tempest_tests/tests/api/test_rules_negative.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 205,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2024-01-27T00:53:32Z",
|
|
"side": 1,
|
|
"message": "the name here can include the parameter so its easier to catch the test case in the o/p:\n\n```\n test_deny_access_without_unrestrict_as_owner_user(self, same_user):\n```",
|
|
"revId": "129fd1cc40a1b5ee671b86d66945acbbc35c8dfe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |