openstack
/
manila-tempest-plugin
Code Issues Proposed changes
manila-tempest-plugin/ba3acbfc1109eb3b957437d6c8c...

481 lines
15 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "8e27ed69_ce8cb02c",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 16643
},
"writtenOn": "2023-10-17T22:25:18Z",
"side": 1,
"message": "please see: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\non how to format your commit message",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 9,
"endChar": 71
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "dd2cfe77_22fc7b5a",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 36180
},
"writtenOn": "2023-10-18T08:17:22Z",
"side": 1,
"message": "Thanks for sharing the wiki page, I made the changes as suggested in wiki.",
"parentUuid": "8e27ed69_ce8cb02c",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 9,
"endChar": 71
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "66c471cc_cace9f6e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 36180
},
"writtenOn": "2023-10-17T09:41:46Z",
"side": 1,
"message": "Below is the test result for share server migration, test are passing when downstream patch trigger the run \nhttps://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/72/1772/2/downstream-share-server-migration/manila-tempest-plugin-ontap-dhss-migration/d8de65f/testr_results.html",
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3deee63e_c475302e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 36180
},
"writtenOn": "2023-10-17T13:03:37Z",
"side": 1,
"message": "recheck",
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "46e2287b_8270c3ef",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 16643
},
"writtenOn": "2023-10-17T22:25:18Z",
"side": 1,
"message": "Thanks Gireesh, some comments inline",
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fcfa830c_463c17b6",
"filename": "manila_tempest_tests/common/waiters.py",
"patchSetId": 1
},
"lineNbr": 49,
"author": {
"id": 16643
},
"writtenOn": "2023-10-17T22:25:18Z",
"side": 1,
"message": "initialize with this default:\n\n`time_out\u003dclient.build_timeout`",
"range": {
"startLine": 49,
"startChar": 29,
"endLine": 49,
"endChar": 42
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e692fd21_172bb4e9",
"filename": "manila_tempest_tests/common/waiters.py",
"patchSetId": 1
},
"lineNbr": 49,
"author": {
"id": 36180
},
"writtenOn": "2023-10-18T08:14:06Z",
"side": 1,
"message": "client is the first parameter we are passing in this function so if I am adding time_out\u003dclient.build_timeout, it is giving compilation error ( unresolved reference client )",
"parentUuid": "fcfa830c_463c17b6",
"range": {
"startLine": 49,
"startChar": 29,
"endLine": 49,
"endChar": 42
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2aa268ea_4b6d6c21",
"filename": "manila_tempest_tests/common/waiters.py",
"patchSetId": 1
},
"lineNbr": 49,
"author": {
"id": 16643
},
"writtenOn": "2023-10-19T04:17:55Z",
"side": 1,
"message": "oh right; \n\nyou could leave timeout\u003dNone and this instead inside the method:\n\n```\n timeout \u003d timeout or client.build_timeout\n```\n\n(please use \"timeout\" instead of \"time_out\" for consistency with the config opt names we have)",
"parentUuid": "e692fd21_172bb4e9",
"range": {
"startLine": 49,
"startChar": 29,
"endLine": 49,
"endChar": 42
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "21e7ca70_5d6b00c6",
"filename": "manila_tempest_tests/common/waiters.py",
"patchSetId": 1
},
"lineNbr": 49,
"author": {
"id": 36180
},
"writtenOn": "2023-10-19T16:06:28Z",
"side": 1,
"message": "done",
"parentUuid": "2aa268ea_4b6d6c21",
"range": {
"startLine": 49,
"startChar": 29,
"endLine": 49,
"endChar": 42
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e7282f7b_b4cc3434",
"filename": "manila_tempest_tests/common/waiters.py",
"patchSetId": 1
},
"lineNbr": 92,
"author": {
"id": 16643
},
"writtenOn": "2023-10-17T22:25:18Z",
"side": 1,
"message": "so that this isn\u0027t necessary",
"range": {
"startLine": 90,
"startChar": 0,
"endLine": 92,
"endChar": 49
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "118092b9_aa209029",
"filename": "manila_tempest_tests/common/waiters.py",
"patchSetId": 1
},
"lineNbr": 92,
"author": {
"id": 36180
},
"writtenOn": "2023-10-18T08:14:06Z",
"side": 1,
"message": "it is require as we can not set time_out value as client.build_timeout as mention in previous comment.",
"parentUuid": "e7282f7b_b4cc3434",
"range": {
"startLine": 90,
"startChar": 0,
"endLine": 92,
"endChar": 49
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4600b45a_6ffdacc3",
"filename": "manila_tempest_tests/common/waiters.py",
"patchSetId": 1
},
"lineNbr": 109,
"author": {
"id": 16643
},
"writtenOn": "2023-10-17T22:25:18Z",
"side": 1,
"message": "when you make the above change, rename this to `timeout`, here and below",
"range": {
"startLine": 109,
"startChar": 39,
"endLine": 109,
"endChar": 69
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1d5f73dd_18689ec7",
"filename": "manila_tempest_tests/common/waiters.py",
"patchSetId": 1
},
"lineNbr": 109,
"author": {
"id": 36180
},
"writtenOn": "2023-10-18T08:14:06Z",
"side": 1,
"message": "As mention in previous reply we can not set time_out as client.build_timeout, so this also not require to change.",
"parentUuid": "4600b45a_6ffdacc3",
"range": {
"startLine": 109,
"startChar": 39,
"endLine": 109,
"endChar": 69
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "25caff96_3585619d",
"filename": "manila_tempest_tests/tests/api/admin/test_share_servers_migration.py",
"patchSetId": 1
},
"lineNbr": 285,
"author": {
"id": 16643
},
"writtenOn": "2023-10-19T04:17:55Z",
"side": 1,
"message": "\"timeout\" for consistency",
"range": {
"startLine": 285,
"startChar": 8,
"endLine": 285,
"endChar": 16
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "17c3b47a_007a8e58",
"filename": "manila_tempest_tests/tests/api/admin/test_share_servers_migration.py",
"patchSetId": 1
},
"lineNbr": 285,
"author": {
"id": 36180
},
"writtenOn": "2023-10-19T16:06:28Z",
"side": 1,
"message": "done",
"parentUuid": "25caff96_3585619d",
"range": {
"startLine": 285,
"startChar": 8,
"endLine": 285,
"endChar": 16
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "30e6e14b_568b0c6d",
"filename": "manila_tempest_tests/tests/api/admin/test_share_servers_migration.py",
"patchSetId": 1
},
"lineNbr": 285,
"author": {
"id": 36180
},
"writtenOn": "2023-10-19T16:06:28Z",
"side": 1,
"message": "Done",
"parentUuid": "25caff96_3585619d",
"range": {
"startLine": 285,
"startChar": 8,
"endLine": 285,
"endChar": 16
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ce086938_ff7aa0e1",
"filename": "manila_tempest_tests/tests/api/base.py",
"patchSetId": 1
},
"lineNbr": 213,
"author": {
"id": 16643
},
"writtenOn": "2023-10-17T22:25:18Z",
"side": 1,
"message": "is this part of the same bugfix? or a different bug?",
"range": {
"startLine": 208,
"startChar": 8,
"endLine": 213,
"endChar": 18
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1d2ba8c2_4e3dd858",
"filename": "manila_tempest_tests/tests/api/base.py",
"patchSetId": 1
},
"lineNbr": 213,
"author": {
"id": 36180
},
"writtenOn": "2023-10-18T08:14:06Z",
"side": 1,
"message": "Yes this is part of same bug. For cifs test we create the share network, security services and then associate the security services to share network.Adding this to make sure if share network already associated with security service and if we are calling \"provide_and_associate_security_services\" method out test should not failed.",
"parentUuid": "ce086938_ff7aa0e1",
"range": {
"startLine": 208,
"startChar": 8,
"endLine": 213,
"endChar": 18
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "58326e30_0207d8b0",
"filename": "manila_tempest_tests/tests/api/base.py",
"patchSetId": 1
},
"lineNbr": 213,
"author": {
"id": 16643
},
"writtenOn": "2023-10-27T23:13:23Z",
"side": 1,
"message": "Thanks for adding this; can you show me / link me to the line where this is being invoked from, and failing?",
"parentUuid": "1d2ba8c2_4e3dd858",
"range": {
"startLine": 208,
"startChar": 8,
"endLine": 213,
"endChar": 18
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8e0cdfb4_b826d527",
"filename": "manila_tempest_tests/tests/api/base.py",
"patchSetId": 1
},
"lineNbr": 213,
"author": {
"id": 36180
},
"writtenOn": "2023-10-30T09:59:14Z",
"side": 1,
"message": "Hi Goutham, just wanted to correct myself here. Even we remove this check non of the test will failed. Initially, CIFS related tests were failing in our environment due to security service was not associated with share network. I have added \"security_service\" parameter in out tempest file and added the code in my test to associate the security service to share network, but it failed with error \"security services already associated with share network\", then I have added this code in lib. Later (after playing with code) I realize that we are creating the share network and adding the security service to share network as part of test setup. I remove the code from my test but I keep the code in lib which return if security service is already associated with share network.\n\nIf you want I can remove this code but I feel adding this validation is good as we can add only one security service to share network (plz correct me if I am wrong here) and if it is already exist then return once condition meet. As of now non of the test case might hit this but in future we can hit this kind of issue.",
"parentUuid": "58326e30_0207d8b0",
"range": {
"startLine": 208,
"startChar": 8,
"endLine": 213,
"endChar": 18
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "276e6e25_1b6d3d7e",
"filename": "manila_tempest_tests/tests/api/base.py",
"patchSetId": 1
},
"lineNbr": 213,
"author": {
"id": 16643
},
"writtenOn": "2023-10-31T22:25:52Z",
"side": 1,
"message": "Hi Gireesh, \n\n\n\u0027provide_and_associate_security_services\u0027 is meant to be invoked optionally: \nhttps://opendev.org/openstack/manila-tempest-plugin/src/commit/4a2f09514f39927a4deb1b3060dd9312037d09e1/manila_tempest_tests/tests/api/base.py#L747\n\nso, if you have a use case where there\u0027s no need to add security services, you just wouldn\u0027t call it.",
"parentUuid": "8e0cdfb4_b826d527",
"range": {
"startLine": 208,
"startChar": 8,
"endLine": 213,
"endChar": 18
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink