Fix share replica creation

The manilaclient SDK not accept a "share_network"
argument anymore with the share_replicas.create()
method.

Change-Id: If21408291fcb4ccd778b24145effcb253227df55
Closes-Bug: #1968925
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

manila_ui/api/manila.py

@@ -464,12 +464,10 @@ def share_replica_list(request, share=None):
     return manilaclient(request).share_replicas.list(share)
 
 
-def share_replica_create(request, share, availability_zone,
-                         share_network=None):
+def share_replica_create(request, share, availability_zone):
     return manilaclient(request).share_replicas.create(
         share,
-        availability_zone=availability_zone,
-        share_network=share_network)
+        availability_zone=availability_zone)
 
 
 def share_replica_get(request, replica):

manila_ui/tests/api/test_manila.py

@@ -811,18 +811,16 @@ class ManilaApiTests(base.APITestCase):
 
         self.manilaclient.share_replicas.list.assert_called_once_with("FOO")
 
-    @ddt.data(None, "foo_share_network")
-    def test_share_replica_create(self, share_network):
+    def test_share_replica_create(self):
         share = "FOO_share"
         availability_zone = "BAR_availability_zone"
 
         api.share_replica_create(
-            self.request, share, availability_zone, share_network)
+            self.request, share, availability_zone)
 
         self.manilaclient.share_replicas.create.assert_called_once_with(
             share,
-            availability_zone=availability_zone,
-            share_network=share_network,
+            availability_zone=availability_zone
         )
 
     def test_share_replica_get(self):

releasenotes/notes/bug-1968925-fix-replica-creation-190321bf9fefe179.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    `Bug #1968925 <https://launchpad.net/bugs/1968925>`_ that was preventing
+    creation of share replicas has been fixed.