openstack/manila-ui
Code Issues Proposed changes

Merge "Workaround SDK bug in listing shares"

Browse Source
This commit is contained in:
Zuul 2022-04-13 11:57:44 +00:00 committed by Gerrit Code Review
commit f971f32781
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
manila_ui/api/manila.py
View File

@ -88,6 +88,7 @@ def manilaclient(request):
def share_list(request, search_opts=None): def share_list(request, search_opts=None):
search_opts = search_opts or {}
return manilaclient(request).shares.list(search_opts=search_opts) return manilaclient(request).shares.list(search_opts=search_opts)

4
manila_ui/tests/api/test_manila.py
View File

@ -33,6 +33,7 @@ class ManilaApiTests(base.APITestCase):
@ddt.data( @ddt.data(
{}, {},
None,
{"name": "fake_share"}, {"name": "fake_share"},
{"limit": "3"}, {"limit": "3"},
{"host": "fake_share_host"}, {"host": "fake_share_host"},
@ -44,8 +45,9 @@ class ManilaApiTests(base.APITestCase):
self.assertEqual( self.assertEqual(
self.manilaclient.shares.list.return_value, result) self.manilaclient.shares.list.return_value, result)
expected_kwargs = kwargs or {}
self.manilaclient.shares.list.assert_called_once_with( self.manilaclient.shares.list.assert_called_once_with(
search_opts=kwargs) search_opts=expected_kwargs)
def test_share_get(self): def test_share_get(self):
api.share_get(self.request, self.id) api.share_get(self.request, self.id)

5
releasenotes/notes/bug-1967312-fix-shares-panel-8b5da4eee68ba6c4.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
`Bug #1967312 <https://launchpad.net/bugs/1967312>`_ that caused the
shares dashboard to fail loading has now been fixed.