openstack/manila
Code Issues Proposed changes
6dad1666de
manila/tox.ini

107 lines
2.9 KiB
INI
Raw Normal View History

Initialize from cinder
2013-08-08 10:34:06 -04:00
[tox]
update min tox version to 2.0 The commands used by constraints need at least tox 2.0. Update to reflect reality, which should help with local running of constraints targets. Change-Id: I27348462a21daab479d76b24b48e3a4e017504cc
2016-07-10 11:50:33 -04:00
minversion = 2.0
Refactor test framework Manila's test framework is pretty old and requires update. Changes: - usage of nose replaced with testr - now all the tests are thread safe - added new options for run_tests.sh, such as --concurrency, --debug, etc... - new '--concurrency' option for run_tests.sh defaults to 1, examples: ./run_tests.sh # will run in 1 thread ./run_tests.sh --concurrency 2 # will run tests in 2 threads - added tools/colorizer.py for colorizing output of testrun with run_tests.sh - tests running with tox use as much threads as cores available by default - examples of testrun with tox: tox # will run test suites defined with 'envlist' in tox.ini, now it is pep8,py26,py27 tox -epy27 # amount of threads is equal to amount of cores tox -epy27 -- --concurrency=2 # amount of threads is 2 tox -epy27 -- --concurrency=4 # amount of threads is 4 - Added 'Database' class to manila.test module, for more conveniant db testing - updated policy file 'manila/tests/policy.json' to allow share-network actions - removed nose-related requirements - added new requirements for testrepository, subunit With merge of this change all old installed virtual environments become incompatible and should be removed with "rm -rf .tox .venv" before testrun. Implements blueprint testr-with-unittests Change-Id: I9579ecd538e29d478dbc12adc7dcc33fc668b397
2014-07-16 13:23:05 +03:00
skipsdist = True
Put py34 first in the env order of tox To solve the problem of "db type could not be determined" on py34 we have to run first the py34 env to, then, run py27. This patch puts py34 first on the tox.ini list of envs to avoid this problem to happen. Change-Id: Id54bb80944385579cfa136fce78cb5be55393f81 Closes-Bug: #1489059
2015-12-02 22:56:19 +08:00
envlist = py34,py27,pep8
Initialize from cinder
2013-08-08 10:34:06 -04:00
[testenv]
setenv = VIRTUAL_ENV={envdir}
Refactor test framework Manila's test framework is pretty old and requires update. Changes: - usage of nose replaced with testr - now all the tests are thread safe - added new options for run_tests.sh, such as --concurrency, --debug, etc... - new '--concurrency' option for run_tests.sh defaults to 1, examples: ./run_tests.sh # will run in 1 thread ./run_tests.sh --concurrency 2 # will run tests in 2 threads - added tools/colorizer.py for colorizing output of testrun with run_tests.sh - tests running with tox use as much threads as cores available by default - examples of testrun with tox: tox # will run test suites defined with 'envlist' in tox.ini, now it is pep8,py26,py27 tox -epy27 # amount of threads is equal to amount of cores tox -epy27 -- --concurrency=2 # amount of threads is 2 tox -epy27 -- --concurrency=4 # amount of threads is 4 - Added 'Database' class to manila.test module, for more conveniant db testing - updated policy file 'manila/tests/policy.json' to allow share-network actions - removed nose-related requirements - added new requirements for testrepository, subunit With merge of this change all old installed virtual environments become incompatible and should be removed with "rm -rf .tox .venv" before testrun. Implements blueprint testr-with-unittests Change-Id: I9579ecd538e29d478dbc12adc7dcc33fc668b397
2014-07-16 13:23:05 +03:00
usedevelop = True
Use upper-constraints in tox installs The tox targets do not currently use upper constaints, resulting in stable branch test runs pulling down newer library versions than what should be supported for those releases. This adds upper-constaints for test environment setup. Change-Id: I1ff164242901a891fb45da03b1595b2e9246a765 Closes-bug: #1596246
2016-06-25 20:00:25 -05:00
install_command = pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}
Delete python bytecode before every test run Because python creates pyc files during tox runs, certain changes in the tree, like deletes of files, or switching branches, can create spurious errors. Change-Id: I9e3b8c8cb0e6df8f3b67ec9d4fc5bc5d25356d16 Closes-Bug: #1520036
2015-11-26 10:58:03 +09:00
whitelist_externals = find
Remove d2to1 dependency Change-Id: I9e91070e61e00cbc7d99ff223e85c3c371f60566
2013-09-30 10:48:26 -04:00
deps = -r{toxinidir}/requirements.txt
-r{toxinidir}/test-requirements.txt
Delete python bytecode before every test run Because python creates pyc files during tox runs, certain changes in the tree, like deletes of files, or switching branches, can create spurious errors. Change-Id: I9e3b8c8cb0e6df8f3b67ec9d4fc5bc5d25356d16 Closes-Bug: #1520036
2015-11-26 10:58:03 +09:00
commands =
find . -type f -name "*.pyc" -delete
Use ostestr to run unit test The ostestr command provides a wrapper around the testr command. By default it also has output that is much more useful for OpenStack’s test including lists of all and failed tests and lists of the 10 slowest tests. ref: http://docs.openstack.org/developer/os-testr/ostestr.html Change-Id: If005d1987b2a4e586cf35f0cc1d07739f84235d2
2016-02-18 23:18:44 +08:00
ostestr {posargs}
Refactor test framework Manila's test framework is pretty old and requires update. Changes: - usage of nose replaced with testr - now all the tests are thread safe - added new options for run_tests.sh, such as --concurrency, --debug, etc... - new '--concurrency' option for run_tests.sh defaults to 1, examples: ./run_tests.sh # will run in 1 thread ./run_tests.sh --concurrency 2 # will run tests in 2 threads - added tools/colorizer.py for colorizing output of testrun with run_tests.sh - tests running with tox use as much threads as cores available by default - examples of testrun with tox: tox # will run test suites defined with 'envlist' in tox.ini, now it is pep8,py26,py27 tox -epy27 # amount of threads is equal to amount of cores tox -epy27 -- --concurrency=2 # amount of threads is 2 tox -epy27 -- --concurrency=4 # amount of threads is 4 - Added 'Database' class to manila.test module, for more conveniant db testing - updated policy file 'manila/tests/policy.json' to allow share-network actions - removed nose-related requirements - added new requirements for testrepository, subunit With merge of this change all old installed virtual environments become incompatible and should be removed with "rm -rf .tox .venv" before testrun. Implements blueprint testr-with-unittests Change-Id: I9579ecd538e29d478dbc12adc7dcc33fc668b397
2014-07-16 13:23:05 +03:00
Add reno for release notes management See mailing list announcement: http://lists.openstack.org/pipermail/openstack-dev/\ 2015-November/078301.html Change-Id: Iac50ba371fcf6cb890bddbef30d846304056f317
2015-11-09 07:56:52 +01:00
[testenv:releasenotes]
commands = sphinx-build -a -E -W -d releasenotes/build/doctrees \
-b html releasenotes/source releasenotes/build/html
In-tree Install Guide The OpenStack install guide team has recommended that projects that are not part of the starter-kit:compute [1] (and a few other projects like Cinder and Horizon) maintain their install guide in-tree. [2] [1] http://governance.openstack.org/reference/tags/starter-kit_compute.html [2] http://git.openstack.org/cgit/openstack/docs-specs/tree/specs/newton/project-specific-installguides.rst Change-Id: I2b49fcfd99b3be40bb1ae7d7b8348abdb5b58b90 Co-Authored-By: Denis Cavalcante <dencaval@gmail.com> Implements: blueprint manila-in-tree-install-guide Partially-implements: blueprint projectspecificinstallguides
2016-05-16 20:36:48 -04:00
[testenv:install-guide]
# builds to install-guide/build/html
commands = sphinx-build -a -E -W -d install-guide/build/doctrees -b html install-guide/source install-guide/build/html
Add debug testenv in tox Once we add debug testenv, we can use "tox -e debug -- --debug" to debug test cases when tox is running. Change-Id: If12d6c7bd8b1ae04096b526ad37978f60fdb70db
2016-01-10 00:38:07 +08:00
[testenv:debug]
commands = oslo_debug_helper {posargs}
[testenv:debug-py27]
basepython = python2.7
commands = oslo_debug_helper {posargs}
[testenv:debug-py34]
basepython = python3.4
commands = oslo_debug_helper {posargs}
Initialize from cinder
2013-08-08 10:34:06 -04:00
[testenv:pep8]
commands =
Remove extra flake8 args By default, flake8 checks the current directory and its subdirectories, so it tests already for "." - and "manila/common" is a subdirectory of it. Thus remove "." and also "manila/common" as subdirectory. Right now "manila/common" gets tested twice - as part of "." and separate. Closes-Bug: #1383154 Change-Id: Ie187686bd8b9e9981b2556c1d394fa9a9ca63915
2014-10-19 18:56:02 +02:00
flake8 {posargs}
Enable bashate during pep8 run bashate checks shell script syntax (similar to pep8 for python). Fix currently available scripts and enable the check for the scripts. Change-Id: I33dc8c44a58f40e8bca9e29cd717caf46e5cd586
2015-01-13 17:33:09 +01:00
# Run bashate during pep8 runs to ensure violations are caught by
# the check and gate queues.
Squash E042 and E043 bashate warnings The bashate tool has been upgraded and now issues new warnings. Squash these E042 and E043 warnings since our shell scripts are doing the right thing currently and changing them to avoid the warnings makes them less readable and more fragile. Change-Id: I25ff337160ab176bb150a6186f6c3198cc068732
2016-05-23 14:52:28 -04:00
bashate -i E006,E042,E043 \
Squash E006 bashate warnings bashate, which is invoked when running 'tox -epep8', currently emits many 'E006: Line too long' warnings. We apparently don't really care about line length in shell scripts and ignore these warnings. This commit instructs bashate to suppress these warnings so that we can see any warnings that we really care about. Change-Id: I565aeaef1f0590e5a6ee6a866974765c748f2965
2016-02-21 10:18:58 -05:00
tools/enable-pre-commit-hook.sh \
Enable bashate during pep8 run bashate checks shell script syntax (similar to pep8 for python). Fix currently available scripts and enable the check for the scripts. Change-Id: I33dc8c44a58f40e8bca9e29cd717caf46e5cd586
2015-01-13 17:33:09 +01:00
contrib/ci/pre_test_hook.sh \
contrib/ci/post_test_hook.sh \
devstack/plugin.sh \
Add Grenade support to Manila Grenade is an OpenStack test harness to exercise the upgrade process between releases. It uses DevStack to perform an initial OpenStack install and as a reference for the final configuration. Add support of it to Manila project, doing following changes: - Add all required scripts for 'grenade' job, such as following: -- settings -- shutdown.sh -- upgrade.sh - Add optional 'resources.sh' script that performs functional tests using bash and manilaclient. List of scenarios: -- 1. create and delete share setting metadata and access rule -- 2. attach security service to share network -- 3. update quotas -- 4. create private share type and add access for project Note following: - Tempest is not used by design. - Manilaclient is used of stable version - version of 'base' devstack, which is 'stable/mitaka'. It also means that used API microversion is latest for that branch. Change-Id: I7d7e0c50933776ca1a710bcf069abb0282b821ac Depends-On: I4232382d3c944666bbf0916a3f285b84f6ff9d64 Implements blueprint grenade
2016-04-07 16:41:59 +03:00
devstack/upgrade/from-mitaka/upgrade-manila \
devstack/upgrade/resources.sh \
devstack/upgrade/shutdown.sh \
devstack/upgrade/upgrade.sh \
Make coverage tox job fail when test coverage was reduced For the moment we can just calculate coverage and generate html with results. It would be really useful to be able to get 'failure' by this job, when latest commit introduced reduction of test coverage by any reason - either addon of new code not covered with unit tests or deletion of existing unit tests. It will reduce total required efforts for code reviewers, that are forced now to perform such check separately and inform about it committer. Added file 'tools/cover.sh' is taken from OpenStack Rally project as of state [1], with couple of fixes for satisfying 'bashate'. Also add configuration file for coverage package. [1] I7b4defe187c0631928d70bd09d7bcea956f4eed3 Change-Id: Ie0c5721985ae48256d9bb26af5fdb4b05797b359
2015-07-23 14:34:28 +03:00
tools/cover.sh \
Remove unused logging import and LOG global This patch removes unused global LOG variable and logging imports from various manila modules, and adds a script to be run as part of pep8 that will ensure that these do not creep back into the codebase. Change-Id: I162c4b2478df45aaf6ea8009b102d6de1a4e309e
2016-04-04 07:01:28 -04:00
tools/check_logging.sh \
Enable bashate during pep8 run bashate checks shell script syntax (similar to pep8 for python). Fix currently available scripts and enable the check for the scripts. Change-Id: I33dc8c44a58f40e8bca9e29cd717caf46e5cd586
2015-01-13 17:33:09 +01:00
run_tests.sh
Detect addition of executable files When running pep8 checks, fail if executable files have accidentally been added. Co-Authored-By: Eric Harney <eharney@redhat.com> Closes-Bug: 1566328 Change-Id: I7280c0403cd473cd4b88cfc021d4f605a7bb35f2
2016-04-04 14:14:07 -04:00
{toxinidir}/tools/check_exec.py {toxinidir}/manila
Remove unused logging import and LOG global This patch removes unused global LOG variable and logging imports from various manila modules, and adds a script to be run as part of pep8 that will ensure that these do not creep back into the codebase. Change-Id: I162c4b2478df45aaf6ea8009b102d6de1a4e309e
2016-04-04 07:01:28 -04:00
{toxinidir}/tools/check_logging.sh {toxinidir}/manila
Initialize from cinder
2013-08-08 10:34:06 -04:00
Replaced manila.conf.sample with README.manila.conf DocImpact Closes-Bug: #1314154 Change-Id: I9ab583f3c3bbe8cf43af2e75a36659519f940186
2014-04-29 14:11:52 +03:00
[testenv:genconfig]
Silence tox warning tox -e genconfig and tox -e pylint both will generate a warning like: WARNING:test command found but not installed in testenv cmd: /bin/bash env: /home/aj/vcs/OpenStack/openstack/manila/.tox/genconfig Maybe forgot to specify a dependency? Whitelist bash to remove the warning. Change-Id: Ibab38ce2308760c7089d5d3e298bfc642367e7b4
2014-10-21 09:37:15 +02:00
whitelist_externals = bash
Replaced manila.conf.sample with README.manila.conf DocImpact Closes-Bug: #1314154 Change-Id: I9ab583f3c3bbe8cf43af2e75a36659519f940186
2014-04-29 14:11:52 +03:00
commands =
Switch to oslo.config The config module in oslo-incubator has been replaced by oslo.config. Projects need to switch completely to oslo.config for kilo. This patch does: * Register options with oslo.config (new file manila/opts.py) * Generate the config file using oslo-config-generator * Remove obsoleted entries for this from openstack-common.conf * Remove oslo-incubator config files Change-Id: I30b594423c08782e13a1f615099ae65f997a8551 Closes-Bug: #1382183
2014-10-16 21:03:03 +02:00
oslo-config-generator --config-file etc/oslo-config-generator/manila.conf
Replaced manila.conf.sample with README.manila.conf DocImpact Closes-Bug: #1314154 Change-Id: I9ab583f3c3bbe8cf43af2e75a36659519f940186
2014-04-29 14:11:52 +03:00
Initialize from cinder
2013-08-08 10:34:06 -04:00
[testenv:venv]
commands = {posargs}
Add specific docs build option to tox Add doc venv to align with other OpenStack projects (such as Keystone, Heat and Nova) who are using 'docs' for their doc builds. Change-Id: Ib26cdac7142e9ec9efc231a578c14bfc7936ae61
2014-08-21 17:03:06 +02:00
[testenv:docs]
commands = python setup.py build_sphinx
Initialize from cinder
2013-08-08 10:34:06 -04:00
[testenv:cover]
Make coverage tox job fail when test coverage was reduced For the moment we can just calculate coverage and generate html with results. It would be really useful to be able to get 'failure' by this job, when latest commit introduced reduction of test coverage by any reason - either addon of new code not covered with unit tests or deletion of existing unit tests. It will reduce total required efforts for code reviewers, that are forced now to perform such check separately and inform about it committer. Added file 'tools/cover.sh' is taken from OpenStack Rally project as of state [1], with couple of fixes for satisfying 'bashate'. Also add configuration file for coverage package. [1] I7b4defe187c0631928d70bd09d7bcea956f4eed3 Change-Id: Ie0c5721985ae48256d9bb26af5fdb4b05797b359
2015-07-23 14:34:28 +03:00
commands = {toxinidir}/tools/cover.sh {posargs}
Initialize from cinder
2013-08-08 10:34:06 -04:00
Add tox fast8 option This commit ports over the fast8 option from cinder, which enables one to run pep8 only on one's changeset rather than against the whole body of code via: tox -efast8 Change-Id: Icb0286c3c66983f2f106c163cb11c690b2c57849
2016-02-21 09:14:13 -05:00
[testenv:fast8]
commands =
{toxinidir}/tools/fast8.sh
Initialize from cinder
2013-08-08 10:34:06 -04:00
[testenv:pylint]
Remove d2to1 dependency Change-Id: I9e91070e61e00cbc7d99ff223e85c3c371f60566
2013-09-30 10:48:26 -04:00
deps = -r{toxinidir}/requirements.txt
Initialize from cinder
2013-08-08 10:34:06 -04:00
pylint==0.26.0
Silence tox warning tox -e genconfig and tox -e pylint both will generate a warning like: WARNING:test command found but not installed in testenv cmd: /bin/bash env: /home/aj/vcs/OpenStack/openstack/manila/.tox/genconfig Maybe forgot to specify a dependency? Whitelist bash to remove the warning. Change-Id: Ibab38ce2308760c7089d5d3e298bfc642367e7b4
2014-10-21 09:37:15 +02:00
whitelist_externals = bash
Initialize from cinder
2013-08-08 10:34:06 -04:00
commands = bash tools/lintstack.sh
Enable developers to see pylint output The program tools/lintstack.py which is executed by tools/lintstack.sh when Jenkins runs, only tests for differences in the output of pylint. Right now, there seems to be 17 errors/warnings that are being carried over from fix to fix, with no difference between fixes, and so no failures in the pylint Jenkins job. It is really difficult to tell what the errors are, so this fix allows developers determine what the errors are by running the following command: $ tox -e lint A sample output of the command is available as an attachment to the bug. Change-Id: I88487829576d55d437b934e08571013b7a6e57cf Signed-off-by: Luis Pabón <lpabon@redhat.com> Closes-Bug: #1356588 Signed-off-by: Luis Pabón <lpabon@redhat.com>
2015-04-03 11:21:40 -04:00
[testenv:lint]
deps = -r{toxinidir}/requirements.txt
pylint==0.26.0
commands = python tools/lintstack.py check
Migrate API reference into tree The API Documentation team has requires [1] that projects maintain their api-reference in-tree and build it to the developer.openstack.org website. This version of the API reference uses os-api-ref and compiles API documentation close to that of the OpenStack compute service (nova). Co-Authored-By: Goutham Pacha Ravi <gouthamr@netapp.com> [0] http://lists.openstack.org/pipermail/openstack-dev/2016-May/093765.html Implements: bp move-manila-api-reference-in-tree Change-Id: I67bb3354162d6e0e00fa2788edde864cc14920ee
2016-05-07 17:18:15 +02:00
[testenv:api-ref]
# This environment is called from CI scripts to test and publish
# the API Ref to developer.openstack.org.
whitelist_externals = rm
commands =
rm -rf api-ref/build
sphinx-build -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html
Add tox job for db revision creation Trivial-Fix Change-Id: Ie87b84ddd546149ca5d9eaf2179c514071c75695
2016-06-22 13:24:35 +02:00
[testenv:dbrevision]
deps = -r{toxinidir}/requirements.txt
commands = alembic -c manila/db/migrations/alembic.ini revision -m ""{posargs}
Initialize from cinder
2013-08-08 10:34:06 -04:00
[flake8]
Enable E121,E122,E123,E124,E125,E129 flake8 tests Enable the tests and update flake8 comments to note that H904 is ignored on purpose. The patch fixes these warnings: ./manila/api/views/limits.py:68:5: E129 visually indented line with same indent as next logical line ./manila/share/drivers/netapp/cluster_mode.py:352:13: E122 continuation line missing indentation or outdented ./manila/scheduler/scheduler_options.py:98:13: E129 visually indented line with same indent as next logical line ./contrib/tempest/tempest/api/share/base.py:210:5: E129 visually indented line with same indent as next logical line ./contrib/tempest/tempest/api/share/test_rules.py:32:13: E129 visually indented line with same indent as next logical line ./contrib/tempest/tempest/api/share/test_rules.py:90:13: E129 visually indented line with same indent as next logical line ./manila/api/views/share_servers.py:28:9: E124 closing bracket does not match visual indentation ./manila/api/views/share_servers.py:34:9: E124 closing bracket does not match visual indentation ./manila/share/drivers/netapp/driver.py:336:5: E125 continuation line with same indent as next logical line Also fixes other pep8 warnings in these files. Partial-Fix: #1333290 Change-Id: Ida14ea8f4716e49f7379f929971fd5e462541527
2014-08-20 10:11:40 +02:00
# Following checks are ignored on purpose:
Removed ignored checks from tox.ini and fixed pep8 issues Due to the hacking version update several pep8 checks where ignored in the flakes8 section of the tox.ini. Removed ignored checks and fixed appropriate pep8 issues. The list of fixed issues: - H105 Don't use author tags - H238 Old style class declaration, use new style (inherit from `object`) - H501 Do not use self.__dict__ for string formatting Closes-Bug: 1530719 Change-Id: I890ba4c54b0da10060767620ff5ff7e480d79a9c
2016-02-14 14:55:46 +02:00
ignore =
Initialize from cinder
2013-08-08 10:34:06 -04:00
builtins = _
In-tree Install Guide The OpenStack install guide team has recommended that projects that are not part of the starter-kit:compute [1] (and a few other projects like Cinder and Horizon) maintain their install guide in-tree. [2] [1] http://governance.openstack.org/reference/tags/starter-kit_compute.html [2] http://git.openstack.org/cgit/openstack/docs-specs/tree/specs/newton/project-specific-installguides.rst Change-Id: I2b49fcfd99b3be40bb1ae7d7b8348abdb5b58b90 Co-Authored-By: Denis Cavalcante <dencaval@gmail.com> Implements: blueprint manila-in-tree-install-guide Partially-implements: blueprint projectspecificinstallguides
2016-05-16 20:36:48 -04:00
exclude = .git,.tox,.testrepository,.venv,build,cover,dist,doc,*egg,api-ref/build,*/source/conf.py
Use oslo.i18n oslo.i18n provides the i18n function that were provided by oslo-incubator's gettextutils module Import _ where needed, oslo.i18n deprecated the builtin method. Closes-Bug: #1382187 Change-Id: I12aa1c725aa4bb52a9aa46e9c3d2b303839de48b
2014-10-16 21:36:13 +02:00
[hacking]
import_exceptions =
manila.i18n
Add manila specific hacking checks Add manila specific hacking checks (copied over from nova) to test: - [M319] Validate that debug level logs are not translated. - [M323] Ensure that the _() function is explicitly imported to ensure proper translations. - [M325] str() cannot be used on an exception. Remove use or use six.text_type() - [M326] Translated messages cannot be concatenated. String should be included in translated message. Also include some tests for the above (copied from nova and adjusted). Rework HACKING.rst to remove the content that is in the global hacking file and add in the manila specific rules. Change-Id: I530609a183c81ba942623b73d5f62cd338b04211
2014-10-17 20:55:03 +02:00
local-check-factory = manila.hacking.checks.factory
Copy Permalink