openstack/manila
Code Issues Proposed changes

Fix manila logging rabbitmq password in debug mode

Browse Source 
Manila will display the rabbitmq password if debugging is enabled.
This patch will ensure that the rabbitmq password is no longer
displayed in the connection log for Manila when debugging is
enabled by looking for the rabbitmq key and not printing it.

There should likely be an effort to utilize Oslo's secret flag for
options to truly fix this issue for this and other sensitive options.

Change-Id: I97cc88354d9b54057350c70c4742055197540d1a
Closes-Bug: 1750074
This commit is contained in:
Dustin Schoenbrun 2018-02-21 10:53:41 -05:00
parent 3a11fc704c
commit 05e4f14ea1
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
manila/service.py
View File

@ -393,6 +393,7 @@ def wait():
# hide flag contents from log if contains a password
# should use secret flag when switch over to openstack-common
if ("_password" in flag or "_key" in flag or
(flag == "transport_url" and "rabbit:" in flag_get) or
(flag == "sql_connection" and "mysql:" in flag_get)):
LOG.debug('%(flag)s : FLAG SET ', {"flag": flag})
else:

4
releasenotes/notes/bug-1750074-fix-rabbitmq-password-in-debug-mode-4e136ff86223c4ea.yaml Normal file
View File

@ -0,0 +1,4 @@
---
fixes:
- rabbitmq password is no longer exposed in the logs when debugging is
enabled.