From 12e1ec4959347a398db358e11a7efdfa579d41f5 Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Tue, 5 Mar 2024 17:37:07 +0900 Subject: [PATCH] Deprecate Windows SMB share driver This feature was added and maintained by Cloudbase as part of effort to support Windows-only OpenStack but Winstackers project was retired and there seems to be no on requiring this deployment architecture now. Because the driver hasn't been get any meaningful update for some time and we no longer have Hyper-V CI active, this proposes deprecating the driver so that we can retire it in 2024.2 at the earliest. [1] d9c0bda0b7afa2bf419bd98b819bbb8315e8d530 Change-Id: Icec29f5512d4c4ce8c8d7ccb1f2d3823bffa7ed9 --- doc/source/admin/generic_driver.rst | 3 +++ manila/share/drivers/windows/windows_smb_driver.py | 2 ++ .../notes/deprecate-windows-smb-654983cf22856e31.yaml | 5 +++++ 3 files changed, 10 insertions(+) create mode 100644 releasenotes/notes/deprecate-windows-smb-654983cf22856e31.yaml diff --git a/doc/source/admin/generic_driver.rst b/doc/source/admin/generic_driver.rst index aabdac97c1..8d24d83f90 100644 --- a/doc/source/admin/generic_driver.rst +++ b/doc/source/admin/generic_driver.rst @@ -259,6 +259,9 @@ Windows SMB driver when Windows VMs are preferred. For more details, please check out the following page: :ref:`windows_smb_driver`. +.. note:: + This driver has been deprecated in 18.0.0 release. + The :mod:`manila.share.drivers.generic` Module ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/manila/share/drivers/windows/windows_smb_driver.py b/manila/share/drivers/windows/windows_smb_driver.py index 3dd32a505f..908470c277 100644 --- a/manila/share/drivers/windows/windows_smb_driver.py +++ b/manila/share/drivers/windows/windows_smb_driver.py @@ -35,6 +35,8 @@ class WindowsSMBDriver(generic.GenericShareDriver): def __init__(self, *args, **kwargs): super(WindowsSMBDriver, self).__init__(*args, **kwargs) + LOG.warning('Windows SMB share driver has been deprecated and is ' + 'expected to be removed in a future release.') self._remote_execute = winrm_helper.WinRMHelper( configuration=self.configuration).execute diff --git a/releasenotes/notes/deprecate-windows-smb-654983cf22856e31.yaml b/releasenotes/notes/deprecate-windows-smb-654983cf22856e31.yaml new file mode 100644 index 0000000000..3a4293fcb5 --- /dev/null +++ b/releasenotes/notes/deprecate-windows-smb-654983cf22856e31.yaml @@ -0,0 +1,5 @@ +--- +deprecations: + - | + The Windows SMB share driver has been deprecated and will be removed in + a future release.