openstack/manila
Code Issues Proposed changes

Fix spurious pylint import errors for ddt and mock

Browse Source 
Set dependencies correctly for pylint job in tox.ini so
it does not report spurious E041 import errors on mock
and ddt modules.  Also fix a reference to Cinder instead
of Manila in the pylint script.

Closes-Bug: #1813156
Change-Id: Ib160caae57e41a4d45483ff4faa599143e694abc
This commit is contained in:
Tom Barron 2019-01-24 07:38:45 -05:00
parent 49afbfc0fc
commit 1838d51925
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/coding-checks.sh
View File

@ -4,7 +4,7 @@ set -eu
usage() { usage() {
echo "Usage: $0 [OPTION]..." echo "Usage: $0 [OPTION]..."
echo "Run Cinder's coding check(s)" echo "Run Manila's coding check(s)"
echo "" echo ""
echo " -Y, --pylint [<basecommit>] Run pylint check on the entire manila module or just files changed in basecommit (e.g. HEAD~1)" echo " -Y, --pylint [<basecommit>] Run pylint check on the entire manila module or just files changed in basecommit (e.g. HEAD~1)"
echo " -h, --help Print this usage message" echo " -h, --help Print this usage message"

1
tox.ini
View File

@ -104,6 +104,7 @@ commands =
[testenv:pylint] [testenv:pylint]
basepython = python3 basepython = python3
deps = -r{toxinidir}/requirements.txt deps = -r{toxinidir}/requirements.txt
-r{toxinidir}/test-requirements.txt
pylint==2.1.1 pylint==2.1.1
whitelist_externals = bash whitelist_externals = bash
commands = bash ./tools/coding-checks.sh --pylint {posargs} commands = bash ./tools/coding-checks.sh --pylint {posargs}