openstack/manila
Code Issues Proposed changes

Fix Share Network Subnet Metadata policy error

Browse Source 
When the user logged is not an admin, the project find for the
policies using some information like project_id. Since the
Subnet model doesn't have project_id, the new property refering
the Share Network project_id now is used to guarantee access

Closes-bug: #2011869
Change-Id: I58331fa6906c855804abb94fad85a8370625c886
This commit is contained in:
renanpiranguinho 2023-03-13 13:34:11 +00:00
parent f03e84ae62
commit 1a603682ae
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manila/db/sqlalchemy/models.py
View File

@ -1066,6 +1066,10 @@ class ShareNetworkSubnet(BASE, ManilaBase):
metadata_dict[meta['key']] = meta['value'] metadata_dict[meta['key']] = meta['value']
return metadata_dict return metadata_dict
@property
def project_id(self):
return self.share_network['project_id']
class ShareNetworkSubnetMetadata(BASE, ManilaBase): class ShareNetworkSubnetMetadata(BASE, ManilaBase):
"""Represents a metadata key/value pair for a subnet.""" """Represents a metadata key/value pair for a subnet."""

6
releasenotes/notes/bug-2006792-fix-add-share-network-subnet-non-admin-463347a723069997.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
Share Network Subnet Metadata now can be add by any user, as the
project_id used to verify the policy in the case of a non-admin user
now is present in the Share Network Subnet db model.