openstack
/
manila
Code Issues Proposed changes

Merge "Don't run periodic_share_replica_update() on active replicas"

This commit is contained in:
Zuul 2021-09-16 20:24:58 +00:00 committed by Gerrit Code Review
parent aa0ba139db 5ba3117f20
commit 2287838bde
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manila/share/manager.py
View File

@ -2603,7 +2603,8 @@ class ShareManager(manager.SchedulerDependentManager):
# Filter only non-active replicas belonging to this backend
def qualified_replica(r):
return (share_utils.extract_host(r['host']) ==
share_utils.extract_host(self.host))
share_utils.extract_host(self.host) and
r['replica_state'] != constants.REPLICA_STATE_ACTIVE)
replicas = list(filter(lambda x: qualified_replica(x), replicas))
for replica in replicas:

6
releasenotes/notes/bug-1924230-skip-periodic-task-for-active-replica-030a982af92f8a62.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- Fixed periodic_share_replica_update() to skip active replicas similarly to
periodic_share_replica_snapshot_update(). The intention is to check on
non-active replicas, that can be 'in_sync', 'out_of_sync' or in 'error'
state.