From 8f5a3f4ffbe1350ebebaa46319f29e75c2375da8 Mon Sep 17 00:00:00 2001 From: Goutham Pacha Ravi Date: Tue, 24 Nov 2020 15:32:11 -0800 Subject: [PATCH] [glusterfs] don't reinit volume list on deletion We don't need to re-initialize the volumes list on deletion, it still makes sense to add a missing volume to the list, going by the reasoning defined in I14835f6c54376737b41cbf78c94908ea1befde15 Related-Bug: #1894362 Change-Id: I96d49f84122a34701328909c929ede4d66746911 (cherry picked from commit 914d87377479ab3951641d658fc461ad2f338ba0) (cherry picked from commit 2ad9bcc1b42819f7a8c7aa7200e6f8d128294205) (cherry picked from commit 312e4d16652383e77d3764777f531ecba4f3f0c8) --- manila/share/drivers/glusterfs/layout_volume.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/manila/share/drivers/glusterfs/layout_volume.py b/manila/share/drivers/glusterfs/layout_volume.py index 882fa97c45..e60c252d66 100644 --- a/manila/share/drivers/glusterfs/layout_volume.py +++ b/manila/share/drivers/glusterfs/layout_volume.py @@ -435,9 +435,8 @@ class GlusterfsVolumeMappedLayout(layout.GlusterfsShareLayoutBase): gmgr.set_vol_option(USER_MANILA_SHARE, 'NONE') gmgr.set_vol_option('nfs.disable', 'on') - # When deleting the share instance, we need to + # When deleting the share instance, we may need to # update'self.gluster_used_vols' again - self.gluster_used_vols = set() self.gluster_used_vols.add(gmgr.qualified) self._push_gluster_vol(gmgr.qualified) except exception.GlusterfsException: