openstack/manila
Code Issues Proposed changes

Can not delete share with error status fixed

Browse Source
This commit is contained in:
Yulia Portnova
2013-09-12 10:27:43 +03:00
parent 19e557f29d
commit 2e2491c97e
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
manila/share/drivers/lvm.py
View File

@@ -131,10 +131,16 @@ class LVMShareDriver(driver.ExecuteMixin, driver.ShareDriver):
"""Deletes a logical volume for share."""
# zero out old volumes to prevent data leaking between users
# TODO(ja): reclaiming space should be done lazy and low priority
self._try_execute('lvremove', '-f', "%s/%s" %
(self.configuration.share_volume_group,
share_name),
run_as_root=True)
try:
self._try_execute('lvremove', '-f', "%s/%s" %
(self.configuration.share_volume_group,
share_name),
run_as_root=True)
except exception.ProcessExecutionError as exc:
if "not found" not in exc.stderr:
LOG.error(_("Error deleting volume: %s") % exc.stderr)
raise
LOG.error(_("Volume not found: %s") % exc.stderr)
def get_share_stats(self, refresh=False):
"""Get share status.