glusterfs: Add GlusterFS driver
Added class GlusterfsShareDriver, derived from manila.share.driver.ShareDriver, implementing create and delete share capabilities and access control. Change-Id: I909ad28d316d071dd1a4790843eae25ade4a9c95
This commit is contained in:
Ram Raja
Csaba Henk
parent
dc253dce03
commit
419ef809ef
|
|
@ -34,3 +34,13 @@ smbcontrol: CommandFilter, /usr/bin/smbcontrol, root
|
|||
# manila/share/drivers/lvm.py: 'net', 'conf', 'setparm', '%s', '%s', '%s'
|
||||
# manila/share/drivers/lvm.py: 'net', 'conf', 'getparm', '%s', 'hosts allow'
|
||||
net: CommandFilter, /usr/bin/net, root
|
||||
|
||||
# manila/share/drivers/glusterfs.py: 'mkdir', '%s'
|
||||
mkdir: CommandFilter, /usr/bin/mkdir, root
|
||||
|
||||
# manila/share/drivers/glusterfs.py: 'rm', '-rf', '%s'
|
||||
rm: CommandFilter, /usr/bin/rm, root
|
||||
|
||||
# manila/share/drivers/glusterfs.py: 'gluster', '--xml', 'volume', 'info', '%s'
|
||||
# manila/share/drivers/glusterfs.py: 'gluster', 'volume', 'set', '%s', 'nfs.export-dir', '%s'
|
||||
gluster: CommandFilter, /usr/sbin/gluster, root
|
||||
|
|
|
|||
|
|
@ -0,0 +1,288 @@
|
|||
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
||||
|
||||
# Copyright (c) 2013 Red Hat, Inc.
|
||||
# All Rights Reserved.
|
||||
#
|
||||
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
||||
# not use this file except in compliance with the License. You may obtain
|
||||
# a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing, software
|
||||
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
||||
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
||||
# License for the specific language governing permissions and limitations
|
||||
# under the License.
|
||||
"""
|
||||
GlusterFS Driver for shares.
|
||||
|
||||
"""
|
||||
import errno
|
||||
import os
|
||||
import pdb
|
||||
from pipes import quote as shellquote
|
||||
import re
|
||||
import xml.etree.cElementTree as etree
|
||||
|
||||
from manila import exception
|
||||
from manila.openstack.common import log as logging
|
||||
from manila.share import driver
|
||||
from manila import utils
|
||||
|
||||
from oslo.config import cfg
|
||||
|
||||
LOG = logging.getLogger(__name__)
|
||||
|
||||
GlusterfsManilaShare_opts = [
|
||||
cfg.StrOpt('glusterfs_volumes_config',
|
||||
default='/etc/manila/glusterfs_volumes',
|
||||
help='File with the list of Gluster volumes that can'
|
||||
'be used to create shares'),
|
||||
cfg.StrOpt('glusterfs_mount_point_base',
|
||||
default='$state_path/mnt',
|
||||
help='Base dir containing mount points for Gluster volumes.'),
|
||||
]
|
||||
|
||||
CONF = cfg.CONF
|
||||
CONF.register_opts(GlusterfsManilaShare_opts)
|
||||
|
||||
_nfs_export_dir = 'nfs.export-dir'
|
||||
|
||||
|
||||
class GlusterAddress(object):
|
||||
|
||||
scheme = re.compile('\A(?:(?P<user>[^:@/]+)@)?'
|
||||
'(?P<host>[^:@/]+):'
|
||||
'/(?P<vol>.+)')
|
||||
|
||||
def __init__(self, address):
|
||||
m = self.scheme.search(address)
|
||||
if not m:
|
||||
raise exception.GlusterfsException('invalid gluster address ' +
|
||||
address)
|
||||
self.remote_user = m.group('user')
|
||||
self.host = m.group('host')
|
||||
self.volume = m.group('vol')
|
||||
self.qualified = address
|
||||
self.export = ':/'.join([self.host, self.volume])
|
||||
|
||||
def make_gluster_args(self, *args):
|
||||
args = ('gluster',) + args
|
||||
kw = {}
|
||||
if self.remote_user:
|
||||
args = ('ssh', '@'.join([self.remote_user, self.host]),
|
||||
' '.join(shellquote(a) for a in args))
|
||||
else:
|
||||
kw['run_as_root'] = True
|
||||
return args, kw
|
||||
|
||||
|
||||
class GlusterfsShareDriver(driver.ExecuteMixin, driver.ShareDriver):
|
||||
"""
|
||||
Glusterfs Specific driver
|
||||
"""
|
||||
|
||||
def __init__(self, db, *args, **kwargs):
|
||||
super(GlusterfsShareDriver, self).__init__(*args, **kwargs)
|
||||
self.db = db
|
||||
self._helpers = None
|
||||
self.gluster_address = None
|
||||
self.configuration.append_config_values(GlusterfsManilaShare_opts)
|
||||
|
||||
def do_setup(self, context):
|
||||
"""Native mount the Gluster volume."""
|
||||
super(GlusterfsShareDriver, self).do_setup(context)
|
||||
self.gluster_address = GlusterAddress(
|
||||
self._read_gluster_vol_from_config()
|
||||
)
|
||||
try:
|
||||
self._execute('mount.glusterfs', check_exit_code=False)
|
||||
except OSError as exc:
|
||||
if exc.errno == errno.ENOENT:
|
||||
raise exception.GlusterfsException(
|
||||
_('mount.glusterfs is not installed'))
|
||||
else:
|
||||
raise
|
||||
|
||||
self._ensure_gluster_vol_mounted()
|
||||
|
||||
def check_for_setup_error(self):
|
||||
"""Is called after do_setup method. Nothing to do."""
|
||||
pass
|
||||
|
||||
def _get_mount_point_for_gluster_vol(self):
|
||||
"""Return mount point for gluster volume."""
|
||||
return os.path.join(self.configuration.glusterfs_mount_point_base,
|
||||
self.gluster_address.volume)
|
||||
|
||||
def _do_mount(self, cmd, ensure):
|
||||
"""Finalize mount command.
|
||||
|
||||
:param cmd: command to do the actual mount
|
||||
:param ensure: boolean to allow remounting a volume with a warning
|
||||
:param glusterfs_export: gluster volume that is mounted
|
||||
"""
|
||||
try:
|
||||
self._execute(*cmd, run_as_root=True)
|
||||
except exception.ProcessExecutionError as exc:
|
||||
if ensure and 'already mounted' in exc.stderr:
|
||||
LOG.warn(_("%s is already mounted"),
|
||||
self.gluster_address.export)
|
||||
else:
|
||||
raise exception.GlusterfsException(
|
||||
'Unable to mount Gluster volume'
|
||||
)
|
||||
|
||||
def _mount_gluster_vol(self, mount_path, ensure=False):
|
||||
"""Mount Gluster volume at the specified mount path."""
|
||||
self._execute('mkdir', '-p', mount_path)
|
||||
command = ['mount', '-t', 'glusterfs', self.gluster_address.export,
|
||||
mount_path]
|
||||
self._do_mount(command, ensure)
|
||||
|
||||
def _read_gluster_vol_from_config(self):
|
||||
config_file = self.configuration.glusterfs_volumes_config
|
||||
if not os.access(config_file, os.R_OK):
|
||||
msg = (_("Gluster config file at %(config)s doesn't exist") %
|
||||
{'config': config})
|
||||
LOG.error(msg)
|
||||
raise exception.GlusterfsException(msg)
|
||||
|
||||
with open(config_file) as f:
|
||||
return f.readline().strip()
|
||||
|
||||
def _get_export_dir_list(self):
|
||||
try:
|
||||
args, kw = self.gluster_address.make_gluster_args(
|
||||
'--xml',
|
||||
'volume',
|
||||
'info',
|
||||
self.gluster_address.volume
|
||||
)
|
||||
out, err = self._execute(*args, **kw)
|
||||
except exception.ProcessExecutionError as exc:
|
||||
LOG.error(_("Error retrieving volume info: %s") % exc.stderr)
|
||||
raise
|
||||
|
||||
if not out:
|
||||
raise exception.GlusterfsException(
|
||||
'Empty answer from gluster command'
|
||||
)
|
||||
|
||||
vix = etree.fromstring(out)
|
||||
if int(vix.find('./volInfo/volumes/count').text) != 1:
|
||||
raise exception.InvalidShare('Volume name ambiguity')
|
||||
export_dir = None
|
||||
for o, v in \
|
||||
((e.find(a).text for a in ('name', 'value'))
|
||||
for e in vix.findall(".//option")):
|
||||
if o == _nfs_export_dir:
|
||||
export_dir = v
|
||||
break
|
||||
if export_dir:
|
||||
return export_dir.split(',')
|
||||
else:
|
||||
return []
|
||||
|
||||
def _ensure_gluster_vol_mounted(self):
|
||||
"""Ensure that a Gluster volume is native-mounted on Manila host.
|
||||
"""
|
||||
mount_path = self._get_mount_point_for_gluster_vol()
|
||||
try:
|
||||
self._mount_gluster_vol(mount_path, ensure=True)
|
||||
except exception.GlusterfsException:
|
||||
LOG.error('Could not mount the Gluster volume %s',
|
||||
self.gluster_address.volume)
|
||||
raise
|
||||
|
||||
def _get_local_share_path(self, share):
|
||||
"""Determine the locally mounted path of the share
|
||||
(in Manila host).
|
||||
"""
|
||||
local_vol_path = self._get_mount_point_for_gluster_vol()
|
||||
if not os.access(local_vol_path, os.R_OK):
|
||||
raise exception.GlusterfsException('share path %s does not exist' %
|
||||
local_vol_path)
|
||||
return os.path.join(local_vol_path, share['name'])
|
||||
|
||||
def create_share(self, ctx, share):
|
||||
"""Create a directory that'd serve as a share in a Gluster volume."""
|
||||
local_share_path = self._get_local_share_path(share)
|
||||
cmd = ['mkdir', local_share_path]
|
||||
try:
|
||||
self._execute(*cmd, run_as_root=True)
|
||||
except exception.ProcessExecutionError:
|
||||
LOG.error('Unable to create share %s', share['name'])
|
||||
raise
|
||||
|
||||
export_location = os.path.join(self.gluster_address.qualified,
|
||||
share['name'])
|
||||
return export_location
|
||||
|
||||
def delete_share(self, context, share):
|
||||
"""Remove a directory that served as a share in a Gluster volume."""
|
||||
local_share_path = self._get_local_share_path(share)
|
||||
cmd = ['rm', '-rf', local_share_path]
|
||||
try:
|
||||
self._execute(*cmd, run_as_root=True)
|
||||
except exception.ProcessExecutionError:
|
||||
LOG.error('Unable to delete share %s', share['name'])
|
||||
raise
|
||||
|
||||
def create_snapshot(self, context, snapshot):
|
||||
"""TBD: Is called to create snapshot."""
|
||||
raise NotImplementedError()
|
||||
|
||||
def create_share_from_snapshot(self, context, share, snapshot):
|
||||
"""Is called to create share from snapshot."""
|
||||
raise NotImplementedError()
|
||||
|
||||
def delete_snapshot(self, context, snapshot):
|
||||
"""TBD: Is called to remove snapshot."""
|
||||
raise NotImplementedError()
|
||||
|
||||
def ensure_share(self, context, share):
|
||||
"""Might not be needed?"""
|
||||
pass
|
||||
|
||||
def _manage_access(self, context, share, access, cbk):
|
||||
"""Manage share access by adjusting the export list with cbk
|
||||
|
||||
cbk is a callable of args (dl, acc), where dl is a list of strings
|
||||
and acc is a string. It should return True (or a value of Boolean
|
||||
reduct True) if it leaves dl intact, and False (or a value of Boolean
|
||||
reduct False) if it makes a change on dl
|
||||
|
||||
cbk will be called with dl being list of currently exported dirs and
|
||||
acc being a textual specification derived from access.
|
||||
"""
|
||||
|
||||
if access['access_type'] != 'ip':
|
||||
raise exception.InvalidShareAccess('only ip access type allowed')
|
||||
export_dir_list = self._get_export_dir_list()
|
||||
access_spec = "/%s(%s)" % (share['name'], access['access_to'])
|
||||
if cbk(export_dir_list, access_spec):
|
||||
return
|
||||
|
||||
export_dir_new = ",".join(export_dir_list)
|
||||
try:
|
||||
args, kw = self.gluster_address.make_gluster_args(
|
||||
'volume', 'set', self.gluster_address.volume,
|
||||
_nfs_export_dir, export_dir_new)
|
||||
self._execute(*args, **kw)
|
||||
except exception.ProcessExecutionError as exc:
|
||||
LOG.error(_("Error in gluster volume set: %s") % exc.stderr)
|
||||
raise
|
||||
|
||||
def allow_access(self, context, share, access):
|
||||
"""NFS export a dir to a volume"""
|
||||
self._manage_access(context, share, access,
|
||||
lambda dl, acc:
|
||||
True if acc in dl else dl.append(acc))
|
||||
|
||||
def deny_access(self, context, share, access):
|
||||
"""Deny access to the share."""
|
||||
self._manage_access(context, share, access,
|
||||
lambda dl, acc:
|
||||
True if acc not in dl else dl.remove(acc))
|
||||
|
|
@ -0,0 +1,468 @@
|
|||
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
||||
|
||||
# Copyright (c) 2014 Red Hat, Inc.
|
||||
# All Rights Reserved.
|
||||
#
|
||||
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
||||
# not use this file except in compliance with the License. You may obtain
|
||||
# a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing, software
|
||||
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
||||
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
||||
# License for the specific language governing permissions and limitations
|
||||
# under the License.
|
||||
|
||||
import errno
|
||||
from mock import Mock
|
||||
from mock import patch
|
||||
import os
|
||||
import subprocess
|
||||
|
||||
from manila import context
|
||||
from manila.db.sqlalchemy import models
|
||||
from manila import exception
|
||||
|
||||
from manila.openstack.common import importutils
|
||||
from manila.openstack.common import log as logging
|
||||
from manila.share import configuration as config
|
||||
from manila.share.drivers import glusterfs
|
||||
from manila import test
|
||||
from manila.tests.db import fakes as db_fakes
|
||||
from manila.tests import fake_utils
|
||||
|
||||
from oslo.config import cfg
|
||||
|
||||
|
||||
CONF = cfg.CONF
|
||||
|
||||
|
||||
gluster_address_attrs = {
|
||||
'export': '127.0.0.1:/testvol',
|
||||
'host': '127.0.0.1',
|
||||
'qualified': 'testuser@127.0.0.1:/testvol',
|
||||
'remote_user': 'testuser',
|
||||
'volume': 'testvol',
|
||||
}
|
||||
|
||||
|
||||
def fake_share(**kwargs):
|
||||
share = {
|
||||
'id': 'fakeid',
|
||||
'name': 'fakename',
|
||||
'size': 1,
|
||||
'share_proto': 'NFS',
|
||||
'export_location': '127.0.0.1:/mnt/nfs/testvol',
|
||||
}
|
||||
share.update(kwargs)
|
||||
return db_fakes.FakeModel(share)
|
||||
|
||||
|
||||
class GlusterAddressTestCase(test.TestCase):
|
||||
"""Tests GlusterAddress."""
|
||||
|
||||
_gluster_args = ('foo', 'bar', "b'a'z")
|
||||
|
||||
def test_gluster_address_init(self):
|
||||
self._gluster_address = glusterfs.GlusterAddress(
|
||||
'testuser@127.0.0.1:/testvol')
|
||||
self.assertEqual(self._gluster_address.remote_user,
|
||||
gluster_address_attrs['remote_user'])
|
||||
self.assertEqual(self._gluster_address.host,
|
||||
gluster_address_attrs['host'])
|
||||
self.assertEqual(self._gluster_address.volume,
|
||||
gluster_address_attrs['volume'])
|
||||
self.assertEqual(self._gluster_address.qualified,
|
||||
gluster_address_attrs['qualified'])
|
||||
self.assertEqual(self._gluster_address.export,
|
||||
gluster_address_attrs['export'])
|
||||
|
||||
def test_gluster_address_invalid(self):
|
||||
self.assertRaises(exception.GlusterfsException,
|
||||
glusterfs.GlusterAddress, '127.0.0.1:vol')
|
||||
|
||||
def test_gluster_address_make_gluster_args_local(self):
|
||||
self._gluster_address = glusterfs.GlusterAddress(
|
||||
'127.0.0.1:/testvol')
|
||||
ret = self._gluster_address.make_gluster_args(*self._gluster_args)
|
||||
self.assertEqual(ret, (('gluster',) + self._gluster_args,
|
||||
{'run_as_root': True}))
|
||||
|
||||
def test_gluster_address_make_gluster_args_remote(self):
|
||||
self._gluster_address = glusterfs.GlusterAddress(
|
||||
'testuser@127.0.0.1:/testvol')
|
||||
ret = self._gluster_address.make_gluster_args(*self._gluster_args)
|
||||
self.assertEqual(len(ret), 2)
|
||||
self.assertEqual(len(ret[0]), 3)
|
||||
# python 2.6 compat thingy
|
||||
check_output = lambda cmd:\
|
||||
subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE).\
|
||||
communicate()[0]
|
||||
# shell unescaping thru echo(1)
|
||||
self.assertEqual(check_output('echo ' + ' '.join(ret[0]),)[:-1],
|
||||
'ssh testuser@127.0.0.1 gluster ' +
|
||||
' '.join(self._gluster_args))
|
||||
self.assertEqual(ret[1], {})
|
||||
|
||||
|
||||
class GlusterfsShareDriverTestCase(test.TestCase):
|
||||
"""Tests GlusterfsShareDriver."""
|
||||
|
||||
def setUp(self):
|
||||
super(GlusterfsShareDriverTestCase, self).setUp()
|
||||
fake_utils.stub_out_utils_execute(self.stubs)
|
||||
self._execute = fake_utils.fake_execute
|
||||
self._context = context.get_admin_context()
|
||||
|
||||
CONF.set_default('glusterfs_mount_point_base', '/mnt/nfs')
|
||||
|
||||
self.fake_conf = config.Configuration(None)
|
||||
self._db = Mock()
|
||||
self._driver = glusterfs.GlusterfsShareDriver(
|
||||
self._db, execute=self._execute,
|
||||
configuration=self.fake_conf)
|
||||
self._driver.gluster_address = Mock(**gluster_address_attrs)
|
||||
self.share = fake_share()
|
||||
|
||||
def tearDown(self):
|
||||
super(GlusterfsShareDriverTestCase, self).tearDown()
|
||||
fake_utils.fake_execute_set_repliers([])
|
||||
fake_utils.fake_execute_clear_log()
|
||||
|
||||
def test_do_setup(self):
|
||||
self._driver._read_gluster_vol_from_config =\
|
||||
Mock(return_value='testuser@127.0.0.1:/testvol/fakename')
|
||||
self._driver._ensure_gluster_vol_mounted = Mock()
|
||||
expected_exec = ['mount.glusterfs']
|
||||
self._driver.do_setup(self._context)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
self._driver._ensure_gluster_vol_mounted.assert_called_once_with()
|
||||
|
||||
def test_do_setup_mount_glusterfs_not_installed(self):
|
||||
self._driver._read_gluster_vol_from_config =\
|
||||
Mock(return_value='testuser@127.0.0.1:/testvol/fakename')
|
||||
|
||||
def exec_runner(*ignore_args, **ignore_kw):
|
||||
raise OSError(errno.ENOENT, os.strerror(errno.ENOENT))
|
||||
|
||||
expected_exec = ['mount.glusterfs']
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0], exec_runner)])
|
||||
self.assertRaises(exception.GlusterfsException, self._driver.do_setup,
|
||||
self._context)
|
||||
|
||||
def test_do_mount(self):
|
||||
expected_exec = ['true']
|
||||
ret = self._driver._do_mount(expected_exec, False)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
self.assertEqual(ret, None)
|
||||
|
||||
def test_do_mount_mounted_noensure(self):
|
||||
def exec_runner(*ignore_args, **ignore_kwargs):
|
||||
raise exception.ProcessExecutionError(stderr='already mounted')
|
||||
expected_exec = ['true']
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0], exec_runner)])
|
||||
self.assertRaises(exception.GlusterfsException, self._driver._do_mount,
|
||||
expected_exec, False)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
|
||||
def test_do_mount_mounted_ensure(self):
|
||||
def exec_runner(*ignore_args, **ignore_kwargs):
|
||||
raise exception.ProcessExecutionError(stderr='already mounted')
|
||||
expected_exec = ['true']
|
||||
glusterfs.LOG.warn = Mock()
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0], exec_runner)])
|
||||
ret = self._driver._do_mount(expected_exec, True)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
self.assertEqual(ret, None)
|
||||
glusterfs.LOG.warn.assert_called_with(
|
||||
"%s is already mounted", self._driver.gluster_address.export)
|
||||
|
||||
def test_do_mount_fail_noensure(self):
|
||||
def exec_runner(*ignore_args, **ignore_kwargs):
|
||||
raise RuntimeError('fake error')
|
||||
expected_exec = ['true']
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0], exec_runner)])
|
||||
self.assertRaises(RuntimeError, self._driver._do_mount,
|
||||
expected_exec, False)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
|
||||
def test_do_mount_fail_ensure(self):
|
||||
def exec_runner(*ignore_args, **ignore_kwargs):
|
||||
raise RuntimeError('fake error')
|
||||
expected_exec = ['true']
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0], exec_runner)])
|
||||
self.assertRaises(RuntimeError, self._driver._do_mount,
|
||||
expected_exec, True)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
|
||||
def test_mount_gluster_vol(self):
|
||||
mount_path = '/mnt/nfs/testvol'
|
||||
self._driver._do_mount = Mock()
|
||||
cmd = ['mount', '-t', 'glusterfs', gluster_address_attrs['export'],
|
||||
mount_path]
|
||||
expected_exec = ['mkdir -p %s' % (mount_path)]
|
||||
|
||||
self._driver._mount_gluster_vol(mount_path)
|
||||
self._driver._do_mount.assert_called_with(cmd, False)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
|
||||
def test_ensure_gluster_vol_mounted(self):
|
||||
mount_path = 'mnt/nfs/testvol'
|
||||
self._driver._mount_gluster_vol = Mock()
|
||||
self._driver._ensure_gluster_vol_mounted()
|
||||
self.assertTrue(self._driver._mount_gluster_vol.called)
|
||||
|
||||
def test_ensure_gluster_vol_mounted_error(self):
|
||||
self._driver._mount_gluster_vol =\
|
||||
Mock(side_effect=exception.GlusterfsException)
|
||||
self.assertRaises(exception.GlusterfsException,
|
||||
self._driver._ensure_gluster_vol_mounted)
|
||||
|
||||
def test_get_export_dir_list_empty_volinfo(self):
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
expected_exec = ['true']
|
||||
self.assertRaises(exception.GlusterfsException,
|
||||
self._driver._get_export_dir_list)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
|
||||
def test_get_export_dir_list_failing_volinfo(self):
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
|
||||
def exec_runner(*ignore_args, **ignore_kwargs):
|
||||
raise RuntimeError('fake error')
|
||||
expected_exec = ['true']
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0], exec_runner)])
|
||||
self.assertRaises(RuntimeError, self._driver._get_export_dir_list)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
|
||||
def test_get_export_dir_list_ambiguous_volinfo(self):
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
|
||||
def exec_runner(*ignore_args, **ignore_kwargs):
|
||||
return """\
|
||||
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
|
||||
<cliOutput>
|
||||
<volInfo>
|
||||
<volumes>
|
||||
<count>0</count>
|
||||
</volumes>
|
||||
</volInfo>
|
||||
</cliOutput>
|
||||
""", ''
|
||||
expected_exec = ['true']
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0], exec_runner)])
|
||||
self.assertRaises(exception.InvalidShare,
|
||||
self._driver._get_export_dir_list)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
|
||||
def test_get_export_dir_list_trivial_volinfo(self):
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
|
||||
def exec_runner(*ignore_args, **ignore_kwargs):
|
||||
return """\
|
||||
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
|
||||
<cliOutput>
|
||||
<volInfo>
|
||||
<volumes>
|
||||
<volume>
|
||||
</volume>
|
||||
<count>1</count>
|
||||
</volumes>
|
||||
</volInfo>
|
||||
</cliOutput>
|
||||
""", ''
|
||||
expected_exec = ['true']
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0], exec_runner)])
|
||||
ret = self._driver._get_export_dir_list()
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
self.assertEqual(ret, [])
|
||||
|
||||
def test_get_export_dir_list(self):
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
|
||||
def exec_runner(*ignore_args, **ignore_kwargs):
|
||||
return """\
|
||||
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
|
||||
<cliOutput>
|
||||
<volInfo>
|
||||
<volumes>
|
||||
<volume>
|
||||
<options>
|
||||
<option>
|
||||
<name>nfs.export-dir</name>
|
||||
<value>foo,bar</value>
|
||||
</option>
|
||||
</options>
|
||||
</volume>
|
||||
<count>1</count>
|
||||
</volumes>
|
||||
</volInfo>
|
||||
</cliOutput>
|
||||
""", ''
|
||||
expected_exec = ['true']
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0], exec_runner)])
|
||||
ret = self._driver._get_export_dir_list()
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
self.assertEqual(ret, ['foo', 'bar'])
|
||||
|
||||
def test_get_local_share_path(self):
|
||||
with patch.object(os, 'access', return_value=True):
|
||||
expected_ret = '/mnt/nfs/testvol/fakename'
|
||||
ret = self._driver._get_local_share_path(self.share)
|
||||
self.assertEqual(ret, expected_ret)
|
||||
|
||||
def test_local_share_path_not_exists(self):
|
||||
with patch.object(os, 'access', return_value=False):
|
||||
self.assertRaises(exception.GlusterfsException,
|
||||
self._driver._get_local_share_path,
|
||||
self.share)
|
||||
|
||||
def test_create_share(self):
|
||||
self._driver._get_local_share_path =\
|
||||
Mock(return_value='/mnt/nfs/testvol/fakename')
|
||||
expected_exec = ['mkdir /mnt/nfs/testvol/fakename', ]
|
||||
expected_ret = 'testuser@127.0.0.1:/testvol/fakename'
|
||||
|
||||
ret = self._driver.create_share(self._context, self.share)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
self.assertEqual(ret, expected_ret)
|
||||
|
||||
def test_cannot_create_share(self):
|
||||
self._driver._get_local_share_path =\
|
||||
Mock(return_value='/mnt/nfs/testvol/fakename')
|
||||
|
||||
def exec_runner(*ignore_args, **ignore_kw):
|
||||
raise exception.ProcessExecutionError
|
||||
|
||||
expected_exec = ['mkdir %s' % (self._driver._get_local_share_path())]
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0],
|
||||
exec_runner)])
|
||||
self.assertRaises(exception.ProcessExecutionError,
|
||||
self._driver.create_share, self._context, self.share)
|
||||
|
||||
def test_delete_share(self):
|
||||
self._driver._get_local_share_path =\
|
||||
Mock(return_value='/mnt/nfs/testvol/fakename')
|
||||
|
||||
expected_exec = ['rm -rf /mnt/nfs/testvol/fakename']
|
||||
|
||||
self._driver.delete_share(self._context, self.share)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
|
||||
def test_cannot_delete_share(self):
|
||||
self._driver._get_local_share_path =\
|
||||
Mock(return_value='/mnt/nfs/testvol/fakename')
|
||||
|
||||
def exec_runner(*ignore_args, **ignore_kw):
|
||||
raise exception.ProcessExecutionError
|
||||
|
||||
expected_exec = ['rm -rf %s' % (self._driver._get_local_share_path())]
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0], exec_runner)])
|
||||
self.assertRaises(exception.ProcessExecutionError,
|
||||
self._driver.delete_share, self._context, self.share)
|
||||
|
||||
def test_manage_access_bad_access_type(self):
|
||||
cbk = Mock()
|
||||
access = {'access_type': 'bad'}
|
||||
self.assertRaises(exception.InvalidShareAccess,
|
||||
self._driver._manage_access,
|
||||
self._context, self.share, access, cbk)
|
||||
|
||||
def test_manage_access_noop(self):
|
||||
cbk = Mock(return_value=True)
|
||||
access = {'access_type': 'ip', 'access_to': '0.0.0.0'}
|
||||
self._driver._get_export_dir_list = Mock()
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
expected_exec = []
|
||||
ret = self._driver._manage_access(self._context, self.share, access,
|
||||
cbk)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
self.assertEqual(ret, None)
|
||||
|
||||
def test_manage_access_adding_entry(self):
|
||||
cbk = list.append
|
||||
access = {'access_type': 'ip', 'access_to': '0.0.0.0'}
|
||||
self._driver._get_export_dir_list =\
|
||||
Mock(return_value=['/example.com(0.0.0.0)'])
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
expected_exec = ['true']
|
||||
ret = self._driver._manage_access(self._context, self.share, access,
|
||||
cbk)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
self.assertEqual(ret, None)
|
||||
self.assertTrue(self._driver.gluster_address.make_gluster_args.called)
|
||||
self.assertEqual(
|
||||
self._driver.gluster_address.make_gluster_args.call_args[0][-1],
|
||||
'/example.com(0.0.0.0),/fakename(0.0.0.0)')
|
||||
|
||||
def test_manage_access_adding_entry_cmd_fail(self):
|
||||
cbk = list.append
|
||||
access = {'access_type': 'ip', 'access_to': '0.0.0.0'}
|
||||
self._driver._get_export_dir_list =\
|
||||
Mock(return_value=['/example.com(0.0.0.0)'])
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
expected_exec = ['true']
|
||||
|
||||
def exec_runner(*ignore_args, **ignore_kw):
|
||||
raise exception.ProcessExecutionError
|
||||
fake_utils.fake_execute_set_repliers([(expected_exec[0],
|
||||
exec_runner)])
|
||||
self.assertRaises(exception.ProcessExecutionError,
|
||||
self._driver._manage_access,
|
||||
self._context, self.share, access, cbk)
|
||||
self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)
|
||||
self.assertTrue(self._driver.gluster_address.make_gluster_args.called)
|
||||
self.assertEqual(
|
||||
self._driver.gluster_address.make_gluster_args.call_args[0][-1],
|
||||
'/example.com(0.0.0.0),/fakename(0.0.0.0)')
|
||||
|
||||
def test_allow_access_with_share_having_noaccess(self):
|
||||
access = {'access_type': 'ip', 'access_to': '0.0.0.0'}
|
||||
self._driver._get_export_dir_list =\
|
||||
Mock(return_value=['/example.com(0.0.0.0)'])
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
self._driver.allow_access(self._context, self.share, access)
|
||||
self.assertTrue(self._driver.gluster_address.make_gluster_args.called)
|
||||
self.assertEqual(
|
||||
self._driver.gluster_address.make_gluster_args.call_args[0][-1],
|
||||
'/example.com(0.0.0.0),/fakename(0.0.0.0)')
|
||||
|
||||
def test_allow_access_with_share_having_access(self):
|
||||
access = {'access_type': 'ip', 'access_to': '0.0.0.0'}
|
||||
self._driver._get_export_dir_list = \
|
||||
Mock(return_value=['/fakename(0.0.0.0)'])
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
self._driver.allow_access(self._context, self.share, access)
|
||||
self.assertFalse(self._driver.gluster_address.make_gluster_args.called)
|
||||
|
||||
def test_deny_access_with_share_having_noaccess(self):
|
||||
access = {'access_type': 'ip', 'access_to': '0.0.0.0'}
|
||||
self._driver._get_export_dir_list = Mock(return_value=[])
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
self._driver.deny_access(self._context, self.share, access)
|
||||
self.assertFalse(self._driver.gluster_address.make_gluster_args.called)
|
||||
|
||||
def test_deny_access_with_share_having_access(self):
|
||||
access = {'access_type': 'ip', 'access_to': '0.0.0.0'}
|
||||
self._driver._get_export_dir_list = \
|
||||
Mock(return_value=['/fakename(0.0.0.0)', '/example.com(0.0.0.0)'])
|
||||
self._driver.gluster_address = Mock(make_gluster_args=
|
||||
Mock(return_value=(('true',), {})))
|
||||
self._driver.deny_access(self._context, self.share, access)
|
||||
self.assertTrue(self._driver.gluster_address.make_gluster_args.called)
|
||||
self.assertEqual(
|
||||
self._driver.gluster_address.make_gluster_args.call_args[0][-1],
|
||||
'/example.com(0.0.0.0)')
|
||||
Loading…
Reference in New Issue