From 49695bde475a30b9e0c949a5926475aaac6911d7 Mon Sep 17 00:00:00 2001 From: vponomaryov Date: Tue, 14 Jun 2016 13:01:00 +0300 Subject: [PATCH] [Tempest] Remove noqa filters Filter noqa is used to avoid expected pep8 failures. But now, tempest has lots of these without any reason. Therefore, remove this filter and unused modules that were discovered as unused without it. Change-Id: I96f8a4a7e7a302f08581eed9e037f388e4c86802 --- manila_tempest_tests/config.py | 2 -- .../services/share/json/shares_client.py | 2 +- .../tests/api/admin/test_admin_actions.py | 6 +++--- .../tests/api/admin/test_migration.py | 4 ++-- .../tests/api/admin/test_migration_negative.py | 6 +++--- .../tests/api/admin/test_multi_backend.py | 6 +++--- .../tests/api/admin/test_scheduler_stats.py | 5 ++--- .../tests/api/admin/test_security_services.py | 2 +- .../tests/api/admin/test_share_networks.py | 2 +- .../tests/api/admin/test_share_servers.py | 8 ++++---- .../tests/api/admin/test_share_types.py | 8 ++++---- .../tests/api/admin/test_share_types_extra_specs.py | 4 ++-- .../tests/api/admin/test_shares_actions.py | 8 ++++---- .../tests/api/test_consistency_groups.py | 8 ++++---- manila_tempest_tests/tests/api/test_extensions.py | 2 +- manila_tempest_tests/tests/api/test_limits.py | 2 +- manila_tempest_tests/tests/api/test_metadata.py | 2 +- .../tests/api/test_metadata_negative.py | 4 ++-- .../tests/api/test_scheduler_stats_negative.py | 4 ++-- .../tests/api/test_security_services.py | 10 +++++----- .../tests/api/test_security_services_mapping.py | 2 +- .../api/test_security_services_mapping_negative.py | 12 ++++++------ .../tests/api/test_security_services_negative.py | 12 ++++++------ .../tests/api/test_share_networks.py | 8 ++++---- .../tests/api/test_share_networks_negative.py | 8 ++++---- .../tests/api/test_shares_negative.py | 8 ++++---- .../tests/scenario/test_share_basic_ops.py | 4 ++-- 27 files changed, 73 insertions(+), 76 deletions(-) diff --git a/manila_tempest_tests/config.py b/manila_tempest_tests/config.py index 4e51ad582e..33e88fbcfb 100644 --- a/manila_tempest_tests/config.py +++ b/manila_tempest_tests/config.py @@ -17,8 +17,6 @@ from __future__ import print_function from oslo_config import cfg -from tempest import config # noqa - service_available_group = cfg.OptGroup(name="service_available", title="Available OpenStack Services") diff --git a/manila_tempest_tests/services/share/json/shares_client.py b/manila_tempest_tests/services/share/json/shares_client.py index bf8ce2a964..eb304f3668 100644 --- a/manila_tempest_tests/services/share/json/shares_client.py +++ b/manila_tempest_tests/services/share/json/shares_client.py @@ -19,7 +19,7 @@ import time import six from six.moves.urllib import parse as urlparse -from tempest import config # noqa +from tempest import config from tempest.lib.common import rest_client from tempest.lib.common.utils import data_utils from tempest.lib import exceptions diff --git a/manila_tempest_tests/tests/api/admin/test_admin_actions.py b/manila_tempest_tests/tests/api/admin/test_admin_actions.py index bc896422b0..40b2460f82 100644 --- a/manila_tempest_tests/tests/api/admin/test_admin_actions.py +++ b/manila_tempest_tests/tests/api/admin/test_admin_actions.py @@ -13,9 +13,9 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import config # noqa -from tempest import test # noqa -import testtools # noqa +from tempest import config +from tempest import test +import testtools from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/admin/test_migration.py b/manila_tempest_tests/tests/api/admin/test_migration.py index f808a44eb7..a5ceaa4845 100644 --- a/manila_tempest_tests/tests/api/admin/test_migration.py +++ b/manila_tempest_tests/tests/api/admin/test_migration.py @@ -13,8 +13,8 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import config # noqa -from tempest import test # noqa +from tempest import config +from tempest import test from manila_tempest_tests.tests.api import base from manila_tempest_tests import utils diff --git a/manila_tempest_tests/tests/api/admin/test_migration_negative.py b/manila_tempest_tests/tests/api/admin/test_migration_negative.py index 348e5fab07..127be0106b 100644 --- a/manila_tempest_tests/tests/api/admin/test_migration_negative.py +++ b/manila_tempest_tests/tests/api/admin/test_migration_negative.py @@ -13,9 +13,9 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import config # noqa -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa +from tempest import config +from tempest.lib import exceptions as lib_exc +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/admin/test_multi_backend.py b/manila_tempest_tests/tests/api/admin/test_multi_backend.py index 57fb9fd62a..20659b1693 100644 --- a/manila_tempest_tests/tests/api/admin/test_multi_backend.py +++ b/manila_tempest_tests/tests/api/admin/test_multi_backend.py @@ -13,9 +13,9 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import config # noqa -from tempest.lib.common.utils import data_utils # noqa -from tempest import test # noqa +from tempest import config +from tempest.lib.common.utils import data_utils +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/admin/test_scheduler_stats.py b/manila_tempest_tests/tests/api/admin/test_scheduler_stats.py index 2fa6be94af..7e1449aa3c 100644 --- a/manila_tempest_tests/tests/api/admin/test_scheduler_stats.py +++ b/manila_tempest_tests/tests/api/admin/test_scheduler_stats.py @@ -12,9 +12,8 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import config # noqa -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa +from tempest import config +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/admin/test_security_services.py b/manila_tempest_tests/tests/api/admin/test_security_services.py index 79169ff6ed..6ba04be274 100644 --- a/manila_tempest_tests/tests/api/admin/test_security_services.py +++ b/manila_tempest_tests/tests/api/admin/test_security_services.py @@ -13,7 +13,7 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import test # noqa +from tempest import test from manila_tempest_tests.tests.api import base from manila_tempest_tests.tests.api import test_security_services diff --git a/manila_tempest_tests/tests/api/admin/test_share_networks.py b/manila_tempest_tests/tests/api/admin/test_share_networks.py index b3df7603eb..1c11647ce0 100644 --- a/manila_tempest_tests/tests/api/admin/test_share_networks.py +++ b/manila_tempest_tests/tests/api/admin/test_share_networks.py @@ -13,7 +13,7 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import test # noqa +from tempest import test from manila_tempest_tests.tests.api import base from manila_tempest_tests.tests.api import test_share_networks diff --git a/manila_tempest_tests/tests/api/admin/test_share_servers.py b/manila_tempest_tests/tests/api/admin/test_share_servers.py index 9509cb1d38..e08a7a4758 100644 --- a/manila_tempest_tests/tests/api/admin/test_share_servers.py +++ b/manila_tempest_tests/tests/api/admin/test_share_servers.py @@ -15,10 +15,10 @@ import re -import six # noqa -from tempest import config # noqa -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa +import six +from tempest import config +from tempest.lib import exceptions as lib_exc +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/admin/test_share_types.py b/manila_tempest_tests/tests/api/admin/test_share_types.py index 5dc462d221..d55b01e3a3 100644 --- a/manila_tempest_tests/tests/api/admin/test_share_types.py +++ b/manila_tempest_tests/tests/api/admin/test_share_types.py @@ -14,10 +14,10 @@ # under the License. import ddt -from tempest import config # noqa -from tempest.lib.common.utils import data_utils # noqa -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa +from tempest import config +from tempest.lib.common.utils import data_utils +from tempest.lib import exceptions as lib_exc +from tempest import test from manila_tempest_tests.tests.api import base from manila_tempest_tests import utils diff --git a/manila_tempest_tests/tests/api/admin/test_share_types_extra_specs.py b/manila_tempest_tests/tests/api/admin/test_share_types_extra_specs.py index 7ee3f7b965..f550ca615f 100644 --- a/manila_tempest_tests/tests/api/admin/test_share_types_extra_specs.py +++ b/manila_tempest_tests/tests/api/admin/test_share_types_extra_specs.py @@ -15,8 +15,8 @@ import copy -from tempest.lib.common.utils import data_utils # noqa -from tempest import test # noqa +from tempest.lib.common.utils import data_utils +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/admin/test_shares_actions.py b/manila_tempest_tests/tests/api/admin/test_shares_actions.py index c8966a2466..49ebfbf37d 100644 --- a/manila_tempest_tests/tests/api/admin/test_shares_actions.py +++ b/manila_tempest_tests/tests/api/admin/test_shares_actions.py @@ -13,10 +13,10 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import config # noqa -from tempest.lib.common.utils import data_utils # noqa -from tempest import test # noqa -import testtools # noqa +from tempest import config +from tempest.lib.common.utils import data_utils +from tempest import test +import testtools from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_consistency_groups.py b/manila_tempest_tests/tests/api/test_consistency_groups.py index 45a462dea1..3c885549df 100644 --- a/manila_tempest_tests/tests/api/test_consistency_groups.py +++ b/manila_tempest_tests/tests/api/test_consistency_groups.py @@ -13,10 +13,10 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import config # noqa -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa -import testtools # noqa +from tempest import config +from tempest.lib import exceptions as lib_exc +from tempest import test +import testtools from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_extensions.py b/manila_tempest_tests/tests/api/test_extensions.py index b9a6c9e2f1..5dde05022b 100644 --- a/manila_tempest_tests/tests/api/test_extensions.py +++ b/manila_tempest_tests/tests/api/test_extensions.py @@ -13,7 +13,7 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import test # noqa +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_limits.py b/manila_tempest_tests/tests/api/test_limits.py index 8348b26ce1..88567b5f6f 100644 --- a/manila_tempest_tests/tests/api/test_limits.py +++ b/manila_tempest_tests/tests/api/test_limits.py @@ -13,7 +13,7 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import test # noqa +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_metadata.py b/manila_tempest_tests/tests/api/test_metadata.py index d0756664f2..bc3efb4933 100644 --- a/manila_tempest_tests/tests/api/test_metadata.py +++ b/manila_tempest_tests/tests/api/test_metadata.py @@ -13,7 +13,7 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import test # noqa +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_metadata_negative.py b/manila_tempest_tests/tests/api/test_metadata_negative.py index 7aec3e5902..51f541a3f6 100644 --- a/manila_tempest_tests/tests/api/test_metadata_negative.py +++ b/manila_tempest_tests/tests/api/test_metadata_negative.py @@ -14,8 +14,8 @@ # under the License. import ddt -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa +from tempest.lib import exceptions as lib_exc +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_scheduler_stats_negative.py b/manila_tempest_tests/tests/api/test_scheduler_stats_negative.py index c9aac84888..a23f2a5db8 100644 --- a/manila_tempest_tests/tests/api/test_scheduler_stats_negative.py +++ b/manila_tempest_tests/tests/api/test_scheduler_stats_negative.py @@ -13,8 +13,8 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa +from tempest.lib import exceptions as lib_exc +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_security_services.py b/manila_tempest_tests/tests/api/test_security_services.py index bd78fb3a87..1acf07cdd3 100644 --- a/manila_tempest_tests/tests/api/test_security_services.py +++ b/manila_tempest_tests/tests/api/test_security_services.py @@ -13,11 +13,11 @@ # License for the specific language governing permissions and limitations # under the License. -from oslo_log import log # noqa -import six # noqa -from tempest import config # noqa -from tempest import test # noqa -import testtools # noqa +from oslo_log import log +import six +from tempest import config +from tempest import test +import testtools from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_security_services_mapping.py b/manila_tempest_tests/tests/api/test_security_services_mapping.py index 33d8ccba62..52cbb7f2a3 100644 --- a/manila_tempest_tests/tests/api/test_security_services_mapping.py +++ b/manila_tempest_tests/tests/api/test_security_services_mapping.py @@ -13,7 +13,7 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import test # noqa +from tempest import test from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_security_services_mapping_negative.py b/manila_tempest_tests/tests/api/test_security_services_mapping_negative.py index 15010da6aa..26e582bce2 100644 --- a/manila_tempest_tests/tests/api/test_security_services_mapping_negative.py +++ b/manila_tempest_tests/tests/api/test_security_services_mapping_negative.py @@ -13,12 +13,12 @@ # License for the specific language governing permissions and limitations # under the License. -from oslo_log import log # noqa -import six # noqa -from tempest import config # noqa -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa -import testtools # noqa +from oslo_log import log +import six +from tempest import config +from tempest.lib import exceptions as lib_exc +from tempest import test +import testtools from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_security_services_negative.py b/manila_tempest_tests/tests/api/test_security_services_negative.py index f7966f599b..1b0a4d3718 100644 --- a/manila_tempest_tests/tests/api/test_security_services_negative.py +++ b/manila_tempest_tests/tests/api/test_security_services_negative.py @@ -13,12 +13,12 @@ # License for the specific language governing permissions and limitations # under the License. -from oslo_log import log # noqa -import six # noqa -from tempest import config # noqa -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa -import testtools # noqa +from oslo_log import log +import six +from tempest import config +from tempest.lib import exceptions as lib_exc +from tempest import test +import testtools from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_share_networks.py b/manila_tempest_tests/tests/api/test_share_networks.py index bd3698b829..ef8bb01f85 100644 --- a/manila_tempest_tests/tests/api/test_share_networks.py +++ b/manila_tempest_tests/tests/api/test_share_networks.py @@ -13,10 +13,10 @@ # License for the specific language governing permissions and limitations # under the License. -import six # noqa -from tempest import config # noqa -from tempest import test # noqa -import testtools # noqa +import six +from tempest import config +from tempest import test +import testtools from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_share_networks_negative.py b/manila_tempest_tests/tests/api/test_share_networks_negative.py index f9b341cbc0..0fb618cba1 100644 --- a/manila_tempest_tests/tests/api/test_share_networks_negative.py +++ b/manila_tempest_tests/tests/api/test_share_networks_negative.py @@ -13,10 +13,10 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import config # noqa -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa -import testtools # noqa +from tempest import config +from tempest.lib import exceptions as lib_exc +from tempest import test +import testtools from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/api/test_shares_negative.py b/manila_tempest_tests/tests/api/test_shares_negative.py index a8a4a6bc36..835aa33a9d 100644 --- a/manila_tempest_tests/tests/api/test_shares_negative.py +++ b/manila_tempest_tests/tests/api/test_shares_negative.py @@ -13,10 +13,10 @@ # License for the specific language governing permissions and limitations # under the License. -from tempest import config # noqa -from tempest.lib import exceptions as lib_exc # noqa -from tempest import test # noqa -import testtools # noqa +from tempest import config +from tempest.lib import exceptions as lib_exc +from tempest import test +import testtools from manila_tempest_tests import share_exceptions from manila_tempest_tests.tests.api import base diff --git a/manila_tempest_tests/tests/scenario/test_share_basic_ops.py b/manila_tempest_tests/tests/scenario/test_share_basic_ops.py index 261a886820..a3e0e1f4fb 100644 --- a/manila_tempest_tests/tests/scenario/test_share_basic_ops.py +++ b/manila_tempest_tests/tests/scenario/test_share_basic_ops.py @@ -14,11 +14,11 @@ # under the License. from oslo_log import log as logging -from tempest import config # noqa +from tempest import config from tempest.lib.common.utils import data_utils from tempest.lib.common.utils import test_utils from tempest.lib import exceptions -from tempest import test # noqa +from tempest import test from manila_tempest_tests.tests.api import base from manila_tempest_tests.tests.scenario import manager_share as manager