From 49f50c9f3521a54caf0094116b4b47b994253c16 Mon Sep 17 00:00:00 2001
From: Elod Illes <elod.illes@est.tech>
Date: Thu, 28 Apr 2022 18:21:39 +0200
Subject: [PATCH] [CI] Install dependencies for docs target

When tox 'docs' target is called, first it installs the dependencies
(listed in 'deps') in 'installdeps' phase, then it installs manila
(with its requirements) in 'develop-inst' phase. In the latter case
'deps' is not used so that the constraints defined in 'deps' are not
used. This could lead to failures on stable branches when new packages
are released that break the build. To avoid this, the simplest solution
is to pre-install requirements, i.e. add requirements.txt to 'docs' tox
target.

Conflicts:
  tox.ini

NOTE(elod.illes): conflict is due to branch specific upper constraints
file link.

Change-Id: I241ab2788b870060e1956a8fc029705378a2a8f4
(cherry picked from commit 9b4c8c92518c25e985c9649b0a7cb430169db712)
(cherry picked from commit 6b644fa8ca3cf8cc8ad394cf4169ee38c2971f9b)
---
 tox.ini | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tox.ini b/tox.ini
index 2dd9d1066b..18e0a66d83 100644
--- a/tox.ini
+++ b/tox.ini
@@ -67,8 +67,12 @@ commands = oslopolicy-sample-generator --config-file=etc/manila/manila-policy-ge
 commands = {posargs}
 
 [testenv:docs]
+# NOTE(elod.illes): requirements.txt is needed because otherwise
+# dependencies are installed during 'develop-inst' tox phase without
+# constraints which could cause failures in stable branches.
 deps =
   -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/xena}
+  -r{toxinidir}/requirements.txt
   -r{toxinidir}/doc/requirements.txt
 commands =
   rm -rf doc/build