openstack/manila
Code Issues Proposed changes

Drop [DEFAULT]root_helper config option

Browse Source 
The option is not used anywhere in the codebase. Manila uses "sudo"
together with "rootwrap".

Change-Id: If276a1bac32f5273c433805263d507e2fc3b2f26
This commit is contained in:
Thomas Bechtold 2019-01-23 07:09:22 +01:00
parent e4156ddb08
commit 5ce6f3843e
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/source/configuration/tables/manila-share.inc
View File

@ -56,8 +56,6 @@
- (Integer) Time to wait for access rules to be allowed/denied on backends when migrating shares using generic approach (seconds). - (Integer) Time to wait for access rules to be allowed/denied on backends when migrating shares using generic approach (seconds).
* - ``network_config_group`` = ``None`` * - ``network_config_group`` = ``None``
- (String) Name of the configuration group in the Manila conf file to look for network config options.If not set, the share backend's config group will be used.If an option is not found within provided group, then'DEFAULT' group will be used for search of option. - (String) Name of the configuration group in the Manila conf file to look for network config options.If not set, the share backend's config group will be used.If an option is not found within provided group, then'DEFAULT' group will be used for search of option.
* - ``root_helper`` = ``sudo``
- (String) Deprecated: command to use for running commands as root.
* - ``share_manager`` = ``manila.share.manager.ShareManager`` * - ``share_manager`` = ``manila.share.manager.ShareManager``
- (String) Full class name for the share manager. - (String) Full class name for the share manager.
* - ``share_name_template`` = ``share-%s`` * - ``share_name_template`` = ``share-%s``

4
manila/common/config.py
View File

@ -106,10 +106,6 @@ global_opts = [
default='month', default='month',
help='Time period to generate share usages for. ' help='Time period to generate share usages for. '
'Time period must be hour, day, month or year.'), 'Time period must be hour, day, month or year.'),
cfg.StrOpt('root_helper',
default='sudo',
help='Deprecated: command to use for running commands as '
'root.'),
cfg.StrOpt('rootwrap_config', cfg.StrOpt('rootwrap_config',
help='Path to the rootwrap configuration file to use for ' help='Path to the rootwrap configuration file to use for '
'running commands as root.'), 'running commands as root.'),

7
releasenotes/notes/remove-root-helper-config-option-fd517b0603031afa.yaml Normal file
View File

@ -0,0 +1,7 @@
---
other:
- |
The "root_helper" configuration option from the [DEFAULT] section
got removed. This option was not used anywhere in the codebase.
Manila uses "sudo" together with "rootwrap" to allow unprivileged users
running actions as root.