openstack/manila
Code Issues Proposed changes

Check project permissions for share replicas

Browse Source 
Fixed the issue of returning more share replicas than we should
be in a project context. Derived project id from parent share in
the share replicas listing query in non-admin share replicas
listing request scenarios.

Change-Id: If28d97a9916ce56d7f7bf93274f5618eee01c209
Closes-Bug: #1922243
Depends-On: I69c31a33c1aad8edae2d90ad6101da1be650be85
This commit is contained in:
Maurice Escher 2021-04-01 18:38:58 +02:00 committed by Goutham Pacha Ravi
parent b7f417afdf
commit 6484de9251
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manila/db/sqlalchemy/api.py
View File

@ -1851,6 +1851,12 @@ def _share_replica_get_with_filters(context, share_id=None, replica_id=None,
query = model_query(context, models.ShareInstance, session=session, query = model_query(context, models.ShareInstance, session=session,
read_deleted="no") read_deleted="no")
if not context.is_admin:
query = query.join(
models.Share,
models.ShareInstance.share_id == models.Share.id).filter(
models.Share.project_id == context.project_id)
if share_id is not None: if share_id is not None:
query = query.filter(models.ShareInstance.share_id == share_id) query = query.filter(models.ShareInstance.share_id == share_id)

8
releasenotes/notes/bug-1922243-fix-project-only-replica-listing-f5f2b95ef14c3ded.yaml Normal file
View File

@ -0,0 +1,8 @@
---
fixes:
- |
Fixed an issue that caused Manila to return all projects' share replicas
even when the user was not an administrator. Now, when the user is not an
administrator, only the replicas in the project perspective are going to
be displayed. For more details, please refer to
`Launchpad Bug #1922243 <https://bugs.launchpad.net/manila/+bug/1922243>`_