openstack
/
manila
Code Issues Proposed changes

Remove unintended exposure of private attribute 

GaneshaNASHelper has a class attribute confrx that is
currently coded up as a public variable. This was unintended.

Made the following changes to fix this:
1. The variable name was updated from confrx to _confrx
per pep8 guidelines for defining non-public variables and instances.
2. All references to this variable have been updated.

Depends-On: Id7d43dee256856062bd0dadad9c469c1500ee36e
Change-Id: Ie4fe96cd9cf9f0ea281c94f5c1378b255f60bada
Co-Authored-By: Andrea Ma <ayma@us.ibm.com>
Co-Authored-By: Andrei Ta <ata@us.ibm.com>
Co-Authored-By: Michael Rowden <mrrowden@us.ibm.com>
Closes-Bug: #1551497
This commit is contained in:
Surya Ghatty 2016-03-02 23:06:19 +00:00
parent 5e4165c8be
commit 6a0bd8c5ad
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manila/share/drivers/ganesha/__init__.py
View File

@ -58,7 +58,7 @@ class GaneshaNASHelper(NASHelperBase):
super(GaneshaNASHelper, self).__init__(execute, config, **kwargs)
self.tag = tag
confrx = re.compile('\.(conf|json)\Z')
_confrx = re.compile('\.(conf|json)\Z')
def _load_conf_dir(self, dirpath, must_exist=True):
"""Load Ganesha config files in dirpath in alphabetic order."""
@ -69,7 +69,7 @@ class GaneshaNASHelper(NASHelperBase):
raise
dirlist = []
LOG.info(_LI('Loading Ganesha config from %s.'), dirpath)
conf_files = list(filter(self.confrx.search, dirlist))
conf_files = list(filter(self._confrx.search, dirlist))
conf_files.sort()
export_template = {}
for conf_file in conf_files: