openstack/manila
Code Issues Proposed changes

Do not put real hostname and IP address to manila config sample

Browse Source 
For the moment, building manila configuration sample, we get real
hostname and IP address of host that runs "genconfig" tox job. It
should not be exposed. So, hide it using "sample_default" arg for
appropriate options.

TrivialFix

Change-Id: Id8e5bdbc352229cf6a908a545e23ce62fd162ca4
This commit is contained in:
Petr Kuběna 2016-06-27 11:48:31 +02:00
parent 420ef92662
commit 6e87a8419a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manila/common/config.py
View File

@ -60,6 +60,7 @@ CONF.register_cli_opts(debug_opts)
global_opts = [
cfg.StrOpt('my_ip',
default=netutils.get_my_ipv4(),
sample_default='<your_ip>',
help='IP address of this host.'),
cfg.StrOpt('scheduler_topic',
default='manila-scheduler',
@ -118,6 +119,7 @@ global_opts = [
help='Full class name for the data manager.'),
cfg.StrOpt('host',
default=socket.gethostname(),
sample_default='<your_hostname>',
help='Name of this node. This can be an opaque identifier. '
'It is not necessarily a hostname, FQDN, or IP address.'),
# NOTE(vish): default to nova for compatibility with nova installs