openstack
/
manila
Code Issues Proposed changes

Replace deprecated library function os.popen() with subprocess 

os.popen() is deprecated since python 2.6. Resolved with use of
subprocess module.

Change-Id: I09f69b57b6dad10a5a6034b39d70f7ab3141bc2a
Closes-Bug: #1529836
This commit is contained in:
Harshada Mangesh Kakad 2015-12-31 02:02:57 -08:00
parent 0af7c9649b
commit 7fb5d6b406
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/source/conf.py
View File

@ -12,6 +12,7 @@
# All configuration values have a default; values that are commented out
# serve to show the default.
import subprocess
import sys
import os
@ -168,8 +169,11 @@ html_theme_options = {}
# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.
#html_last_updated_fmt = '%b %d, %Y'
git_cmd = "git log --pretty=format:'%ad, commit %h' --date=local -n1"
html_last_updated_fmt = os.popen(git_cmd).read()
git_cmd = [
"git", "log", "--pretty=format:'%ad, commit %h'", "--date=local", "-n1"
]
html_last_updated_fmt = subprocess.Popen(
git_cmd, stdout=subprocess.PIPE).communicate()[0]
# If true, SmartyPants will be used to convert quotes and dashes to
# typographically correct entities.