From 60ae6a7b208fabec9590bc9c5a0abfc78d325bf9 Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Mon, 20 Mar 2023 18:31:52 +0900 Subject: [PATCH] [coordination] backend_url should be secret The backend_url option can sometimes contain secrets. For example when redis coordination backend is used and authentication is enabled in redis, the plain redis password is put as an URL element. [coordination] backend_url=redis://:password@127.0.0.1:6379 Closes-Bug: #2012246 Change-Id: Ia815720cedda2f5c70205ffda5c765364cee8f8c (cherry picked from commit 8ec46875665e93daf252a9feaf9d36d354c3660c) (cherry picked from commit 5da7be292664194d9845d1ae77fba821f97ff7fe) (cherry picked from commit 98ea6ac7688be7376a3d3512c69b5905c9738a01) (cherry picked from commit b73958504c3638882ddd992c91317d70b0a2d444) --- manila/coordination.py | 1 + 1 file changed, 1 insertion(+) diff --git a/manila/coordination.py b/manila/coordination.py index a8b9feda8a..008b6d215a 100644 --- a/manila/coordination.py +++ b/manila/coordination.py @@ -31,6 +31,7 @@ LOG = log.getLogger(__name__) coordination_opts = [ cfg.StrOpt('backend_url', + secret=True, default='file://$state_path', help='The back end URL to use for distributed coordination.') ]