openstack
/
manila
Code Issues Proposed changes

Tempest: wrong assertion on the number of shares created 

Two of the tests targeting share listing contain a wrong assertion on the
number of existing shares. It is asserted that more than one shares exist,
while in case snapshot tests are disabled, only one share is created
during resource setup.

This patch fixes those tests by lowering the expected minimum
number of shares to 1.

Change-Id: I28c5d7d61425c20a657af25532e5495b2ebea360
Closes-Bug: #1489846
This commit is contained in:
Alin Balutoiu 2015-08-28 14:39:22 +03:00
parent 4d0ed8411c
commit 94a750dbe8
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/tempest/tempest/api/share/admin/test_shares_actions.py
View File

@ -246,7 +246,7 @@ class SharesActionsAdminTest(base.BaseSharesAdminTest):
shares = self.shares_client.list_shares_with_detail(params=filters)
# verify response
self.assertTrue(len(shares) > 1)
self.assertTrue(len(shares) > 0)
for share in shares:
self.assertEqual(
filters['share_network_id'], share['share_network_id'])

2
contrib/tempest/tempest/api/share/test_shares_actions.py
View File

@ -173,7 +173,7 @@ class SharesActionsTest(base.BaseSharesTest):
shares = self.shares_client.list_shares_with_detail(params=filters)
# verify response
self.assertTrue(len(shares) > 1)
self.assertTrue(len(shares) > 0)
for share in shares:
self.assertEqual(
filters['share_network_id'], share['share_network_id'])