openstack/manila
Code Issues Proposed changes

Fix mutable config in manila-scheduler

Browse Source 
We had SIGHUP apply the "mutate" behavior to the
ProcessLauncher with [1], however, the scheduler
process does not use ProcessLauncher.

Oslo config made "debug" a mutable config option
in [3]

Closes-Bug: #1785129

[1] I6499ae6c98d9489a123bb20febd6c1ddb9e17b86
[3] I1e7a69de169cc85f4c09954b2f46ce2da7106d90

Change-Id: Ifffe3cad0f5cd52988ce253794efc5b03ea9840b
This commit is contained in:
Saju.Madhavan 2018-07-26 02:46:17 +05:30 committed by Tom Barron
parent 7dd147874d
commit 9da534344a
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manila/service.py
View File

@ -383,7 +383,8 @@ def serve(server, workers=None):
global _launcher global _launcher
if _launcher: if _launcher:
raise RuntimeError('serve() can only be called once') raise RuntimeError('serve() can only be called once')
_launcher = service.launch(CONF, server, workers=workers) _launcher = service.launch(CONF, server, workers=workers,
restart_method='mutate')
def wait(): def wait():

5
releasenotes/notes/bug-1785129-fix-sighup-behavior-with-scheduler-8ee803ad0e543cce.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- The SIGHUP behavior for the manila-scheduler service has been fixed.
Previously, only the manila-share service was responding to SIGHUP and
reloading its configuration, now manila-scheduler does the same.