From a700e1e5d31521d459edf3d098bbfe4f8b9b4790 Mon Sep 17 00:00:00 2001 From: nidhimittalhada Date: Thu, 7 Jan 2016 17:03:46 +0530 Subject: [PATCH] A tempest test in services API using unsafe assert Test "test_get_service_by_invalid_params" performs unsafe assertions where two lists are compared and it fails when order of inner elements is different, but this case should be considered OK. Change-Id: I15efc590d45afb6e025c0e920177c58e57eebadb Closes-Bug: #1531667 --- .../tests/api/admin/test_services_negative.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/manila_tempest_tests/tests/api/admin/test_services_negative.py b/manila_tempest_tests/tests/api/admin/test_services_negative.py index 07914d3c78..a229c45d7f 100644 --- a/manila_tempest_tests/tests/api/admin/test_services_negative.py +++ b/manila_tempest_tests/tests/api/admin/test_services_negative.py @@ -47,7 +47,13 @@ class ServicesAdminNegativeTest(base.BaseSharesAdminTest): # so do not take it in account. for service in services + services_fake: service["updated_at"] = "removed_possible_difference" - self.assertEqual(services, services_fake) + + msg = ('Unexpected service list. Expected %s, got %s.' % + (services, services_fake)) + self.assertEqual(sorted(services, key=lambda service: service['id']), + sorted(services_fake, + key=lambda service: service['id']), + msg) @test.attr(type=["gate", "smoke", "negative", ]) def test_get_service_by_invalid_host(self):