openstack
/
manila
Code Issues Proposed changes

Fix tempest test with share server listing with no filters 

We have test in tempest plugin that gets list of share servers
and verifies server being used is present, but also verifies
that all share servers have some specific states. It is incorrect
because share servers from whole cluster are taken. And these 'all'
share servers are not related to test.

Change-Id: Iae849cb64ca36448eb5fa28a2075de614fea475c
This commit is contained in:
vponomaryov 2014-12-20 13:46:20 +02:00 committed by Valeriy Ponomaryov
parent 15fcc9e6a4
commit b0e4b260a1
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
contrib/tempest/tempest/api/share/admin/test_share_servers.py
View File

@ -73,13 +73,10 @@ class ShareServersAdminTest(base.BaseSharesAdminTest):
# Project id is not empty
self.assertTrue(len(server["project_id"]) > 0)
# Do not verify statuses because we get all share servers from whole
# cluster and here can be servers with any state.
# Server we used is present.
# Use 'allowed_statuses' to cover possible statuses of share servers
# in general, because we get info for whole cluster.
allowed_statuses = ["active", "creating", "deleting"]
any((s["share_network_name"] in self.sn_name_and_id and
self.assertIn(s["status"].lower(),
allowed_statuses)) for s in servers)
any(s["share_network_name"] in self.sn_name_and_id for s in servers)
@test.attr(type=["gate", "smoke", ])
def test_list_share_servers_with_host_filter(self):