openstack/manila
Code Issues Proposed changes

NetApp cDOT assume disabled compression on empty result

Browse Source 
can happen when sis is disabled

Change-Id: Icd22838d2d77278c8d8479905ce1ea78baa862a9
Closes-Bug: #1804654
This commit is contained in:
Maurice Schreiber 2018-04-27 10:27:14 +02:00 committed by silvacarloss
parent d9026c7183
commit b1ced07ffe
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
manila/share/drivers/netapp/dataontap/client/client_cmode.py
View File

@ -1623,12 +1623,16 @@ class NetAppCmodeClient(client_base.NetAppBaseClient):
},
},
}
result = self.send_iter_request('sis-get-iter', api_args)
attributes_list = result.get_child_by_name(
'attributes-list') or netapp_api.NaElement('none')
sis_status_info = attributes_list.get_child_by_name(
'sis-status-info') or netapp_api.NaElement('none')
try:
result = self.send_iter_request('sis-get-iter', api_args)
attributes_list = result.get_child_by_name(
'attributes-list') or netapp_api.NaElement('none')
sis_status_info = attributes_list.get_child_by_name(
'sis-status-info') or netapp_api.NaElement('none')
except exception.NetAppException:
msg = _('Failed to get volume efficiency status for %s.')
LOG.error(msg, volume_name)
sis_status_info = netapp_api.NaElement('none')
return {
'dedupe': True if 'enabled' == sis_status_info.get_child_content(

4
releasenotes/notes/fix-volume-efficiency-status-2102ad630c5407a8.yaml Normal file
View File

@ -0,0 +1,4 @@
fixes:
- |
Fixed an issue while getting efficiency status from the NetApp
backend while creating or updating volumes.