From bcc7e2c365d0620b01a6dd0b0782149ca8a06cf8 Mon Sep 17 00:00:00 2001 From: Gerrit User 29632 <29632@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 5 Aug 2021 20:36:00 +0000 Subject: [PATCH] Update patch set 10 Patch Set 10: Code-Review+2 (2 comments) Looking good, Kiran! Thank you for your patience with this change. Patch-set: 10 Reviewer: Gerrit User 29632 <29632@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+2 --- 21c84b63f16ee42d9f06e0bf6b22abeeae39a7bd | 27 ++++++++++++++++++++++++ c949816dbf7ac92ff547d89bd5c9aad02626aea5 | 24 +++++++++++++++++++++ 2 files changed, 51 insertions(+) create mode 100644 21c84b63f16ee42d9f06e0bf6b22abeeae39a7bd diff --git a/21c84b63f16ee42d9f06e0bf6b22abeeae39a7bd b/21c84b63f16ee42d9f06e0bf6b22abeeae39a7bd new file mode 100644 index 0000000000..0e1ad5c2ac --- /dev/null +++ b/21c84b63f16ee42d9f06e0bf6b22abeeae39a7bd @@ -0,0 +1,27 @@ +{ + "comments": [ + { + "key": { + "uuid": "197513c8_c4bda959", + "filename": "releasenotes/notes/bug-1900752-early-validate-mandatory-security-service-association-f48aecbbc47418cd.yaml", + "patchSetId": 10 + }, + "lineNbr": 7, + "author": { + "id": 29632 + }, + "writtenOn": "2021-08-05T20:36:00Z", + "side": 1, + "message": "From now on,", + "range": { + "startLine": 6, + "startChar": 42, + "endLine": 7, + "endChar": 8 + }, + "revId": "21c84b63f16ee42d9f06e0bf6b22abeeae39a7bd", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true + } + ] +} \ No newline at end of file diff --git a/c949816dbf7ac92ff547d89bd5c9aad02626aea5 b/c949816dbf7ac92ff547d89bd5c9aad02626aea5 index c40065b5e3..d7c24d59ec 100644 --- a/c949816dbf7ac92ff547d89bd5c9aad02626aea5 +++ b/c949816dbf7ac92ff547d89bd5c9aad02626aea5 @@ -94,6 +94,30 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": true }, + { + "key": { + "uuid": "cf94bc49_bdc47318", + "filename": "manila/tests/share/test_manager.py", + "patchSetId": 8 + }, + "lineNbr": 2489, + "author": { + "id": 29632 + }, + "writtenOn": "2021-08-05T20:36:00Z", + "side": 1, + "message": "No worries, Kiran!", + "parentUuid": "49e9c60d_35a35f05", + "range": { + "startLine": 2488, + "startChar": 8, + "endLine": 2489, + "endChar": 60 + }, + "revId": "c949816dbf7ac92ff547d89bd5c9aad02626aea5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true + }, { "key": { "uuid": "aa7e6e33_beb37ff6",