Fix GaneshaNASHelper update_access signature

The gluster GaneshaNFSHelper update_access method calls
into the GaneshaNASHelper update_access method, but the
signature it uses for this call is not up to date with
the 2017 dynamic export changes made to the Ganesha
driver.

Fix this by adding an update_access method to
the gluster-specific GaneshaNFSHelper which accepts
the signature that the Gluster driver expects but calls
into Ganesha with the signature that it expects.

[1] Change-Id: I01ec100c0afe28a84e9afa8e0660d299e4b3d160

Closes-Bug: #1964696
Change-Id: I2cae5ba54ae0a95e84d5ef7cf0f05287b7ae5d22
(cherry picked from commit 6f4191a6d9)
This commit is contained in:
Tom Barron 2022-03-14 15:29:11 -04:00 committed by Goutham Pacha Ravi
parent 8817389ada
commit c37a44dfe6
2 changed files with 17 additions and 0 deletions

View File

@ -309,3 +309,13 @@ class GaneshaNFSHelper(ganesha.GaneshaNASHelper):
return {"Hostname": self.gluster_manager.host,
"Volume": self.gluster_manager.volume,
"Volpath": self.gluster_manager.path}
def update_access(self, base_path, share, add_rules, delete_rules,
recovery=False):
"""Update access rules."""
context = None
access_rules = []
super(GaneshaNFSHelper, self).update_access(
context, share, access_rules, add_rules,
delete_rules, share_server=None)

View File

@ -0,0 +1,7 @@
---
fixes:
- |
`Bug #1964696 <https://bugs.launchpad.net/manila/+bug/1964696>`_: Fix
calling the GaneshaNASHelper `update_access` method from the gluster
GaneshaNFSHelper with the wrong signature.