openstack/manila
Code Issues Proposed changes

Merge "Implement secure RBAC for share type extra spec"

Browse Source
This commit is contained in:
Zuul 2021-03-12 03:15:51 +00:00 committed by Gerrit Code Review
commit c730272f22
1 changed files with 62 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
manila/policies/share_types_extra_spec.py
View File

@ -10,6 +10,7 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from oslo_log import versionutils
from oslo_policy import policy from oslo_policy import policy
from manila.policies import base from manila.policies import base
@ -17,57 +18,108 @@ from manila.policies import base
BASE_POLICY_NAME = 'share_types_extra_spec:%s' BASE_POLICY_NAME = 'share_types_extra_spec:%s'
DEPRECATED_REASON = """
The share types extra specs API now supports system scope and default roles.
"""
deprecated_extra_spec_create = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'create',
check_str=base.RULE_ADMIN_API
)
deprecated_extra_spec_show = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_ADMIN_API
)
deprecated_extra_spec_index = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_ADMIN_API
)
deprecated_extra_spec_update = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'update',
check_str=base.RULE_ADMIN_API
)
deprecated_extra_spec_delete = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'delete',
check_str=base.RULE_ADMIN_API
)
share_types_extra_spec_policies = [ share_types_extra_spec_policies = [
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'create', name=BASE_POLICY_NAME % 'create',
check_str=base.RULE_ADMIN_API, check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Create share type extra spec.", description="Create share type extra spec.",
operations=[ operations=[
{ {
'method': 'POST', 'method': 'POST',
'path': '/types/{share_type_id}/extra_specs', 'path': '/types/{share_type_id}/extra_specs',
} }
]), ],
deprecated_rule=deprecated_extra_spec_create,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'show', name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_ADMIN_API, check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Get share type extra specs of a given share type.", description="Get share type extra specs of a given share type.",
operations=[ operations=[
{ {
'method': 'GET', 'method': 'GET',
'path': '/types/{share_type_id}/extra_specs', 'path': '/types/{share_type_id}/extra_specs',
} }
]), ],
deprecated_rule=deprecated_extra_spec_show,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'index', name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_ADMIN_API, check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Get details of a share type extra spec.", description="Get details of a share type extra spec.",
operations=[ operations=[
{ {
'method': 'GET', 'method': 'GET',
'path': '/types/{share_type_id}/extra_specs/{extra_spec_id}', 'path': '/types/{share_type_id}/extra_specs/{extra_spec_id}',
}, },
]), ],
deprecated_rule=deprecated_extra_spec_index,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'update', name=BASE_POLICY_NAME % 'update',
check_str=base.RULE_ADMIN_API, check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Update share type extra spec.", description="Update share type extra spec.",
operations=[ operations=[
{ {
'method': 'PUT', 'method': 'PUT',
'path': '/types/{share_type_id}/extra_specs', 'path': '/types/{share_type_id}/extra_specs',
} }
]), ],
deprecated_rule=deprecated_extra_spec_update,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'delete', name=BASE_POLICY_NAME % 'delete',
check_str=base.RULE_ADMIN_API, check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Delete share type extra spec.", description="Delete share type extra spec.",
operations=[ operations=[
{ {
'method': 'DELETE', 'method': 'DELETE',
'path': '/types/{share_type_id}/extra_specs/{key}', 'path': '/types/{share_type_id}/extra_specs/{key}',
} }
]), ],
deprecated_rule=deprecated_extra_spec_delete,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
] ]