openstack/manila
Code Issues Proposed changes

Fix misuse of assertTrue

Browse Source 
Change-Id: Ic3d3d32c3f7d624846f644601ee1ca01a103882a
Closes-Bug: 1989250
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
This commit is contained in:
Takashi Natsume 2022-09-10 20:49:43 +09:00
parent a1730ea8a6
commit c8c4989d43
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manila/tests/scheduler/filters/test_json.py
View File

@ -270,7 +270,7 @@ class HostFiltersTestCase(test.TestCase):
} }
host = fakes.FakeHostState('host1', host = fakes.FakeHostState('host1',
{'capabilities': {'enabled': True}}) {'capabilities': {'enabled': True}})
self.assertTrue(self.filter.host_passes, (host, filter_properties)) self.assertTrue(self.filter.host_passes(host, filter_properties))
def test_json_filter_empty_filters_pass(self): def test_json_filter_empty_filters_pass(self):
host = fakes.FakeHostState('host1', host = fakes.FakeHostState('host1',

5
manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_base.py
View File

@ -152,9 +152,10 @@ class NetAppFileStorageLibraryTestCase(test.TestCase):
mock_set_cluster_info.assert_called_once() mock_set_cluster_info.assert_called_once()
def test_set_cluster_info(self): def test_set_cluster_info(self):
self.library._client.is_nve_supported.return_value = True
self.library._client.features.FLEXVOL_ENCRYPTION = True
self.library._set_cluster_info() self.library._set_cluster_info()
self.assertTrue(self.library._cluster_info['nve_support'], self.assertTrue(self.library._cluster_info['nve_support'])
fake.CLUSTER_NODES)
def test_check_for_setup_error(self): def test_check_for_setup_error(self):
mock_start_periodic_tasks = self.mock_object(self.library, mock_start_periodic_tasks = self.mock_object(self.library,