skip periodic update on replicas in 'error_deleting'

Change-Id: I737dbc5138c81e6708b9ebae7e7c11622e124a3d
Closes-Bug: #2024578

manila/share/manager.py

@@ -2723,6 +2723,7 @@ class ShareManager(manager.SchedulerDependentManager):
         # We don't poll for replicas that are busy in some operation,
         # or if they are the 'active' instance.
         if (share_replica['status'] in constants.TRANSITIONAL_STATUSES
+            or share_replica['status'] == constants.STATUS_ERROR_DELETING
             or share_replica['replica_state'] ==
                 constants.REPLICA_STATE_ACTIVE):
             return

releasenotes/notes/bug-2024556-skip-error-deleting-replicas-aa2ef4154d5e38f6.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Share replicas in state `error_deleting` are now skipped during periodic
+    updates. For more details, please refer to
+    `launchpad bug #2024556 <https://bugs.launchpad.net/manila/+bug/2024556>`_